Skip to content

chore(deps): bump open-feature/sdk to 2.3.0 - #141

Merged
jonathannorris merged 1 commit into
mainfrom
chore/of-sdk-bump
Aug 6, 2026
Merged

chore(deps): bump open-feature/sdk to 2.3.0#141
jonathannorris merged 1 commit into
mainfrom
chore/of-sdk-bump

Conversation

@jonathannorris

@jonathannorris jonathannorris commented Aug 5, 2026

Copy link
Copy Markdown
Member

Summary

  • Bumps open-feature/sdk from 2.0.10 to 2.3.0 and raises the constraint floor to ^2.3.0
  • Wires up setLogger() using the SDK's own LoggerAwareTrait, replacing the TODO stub
  • 22 tests, 119 assertions, passing and identical to a pre-upgrade baseline

Notes

^2.0.10 already allowed 2.3.0, so the functional change is the lockfile. I raised the floor to match what we now test against, still open across 2.x. The Provider interface is unchanged in 2.3.0, so the upgrade itself needed no code changes.

setLogger() now satisfies LoggerAwareInterface and makes the injected logger retrievable, but no resolve path emits log lines yet. That needs the five duplicated resolve*Value() methods collapsed into a shared helper first.

@jonathannorris
jonathannorris marked this pull request as ready for review August 5, 2026 20:17
@jonathannorris
jonathannorris requested a review from a team as a code owner August 5, 2026 20:17

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the project’s OpenFeature PHP SDK dependency to open-feature/sdk v2.3.0 (and raises the minimum compatible constraint), and replaces the previous setLogger() TODO stub in DevCycleProvider with the SDK-provided LoggerAwareTrait implementation.

Changes:

  • Bump open-feature/sdk constraint from ^2.0.10 to ^2.3.0 in composer.json.
  • Update composer.lock to lock open-feature/sdk to 2.3.0.
  • Implement logger wiring in DevCycleProvider by using OpenFeature\interfaces\common\LoggerAwareTrait and removing the empty setLogger() stub.

Reviewed changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.

File Description
lib/OpenFeature/DevCycleProvider.php Replaces the TODO setLogger() stub by mixing in the OpenFeature SDK’s LoggerAwareTrait (adds setLogger() + getLogger() behavior).
composer.json Raises the minimum open-feature/sdk version to ^2.3.0.
composer.lock Locks open-feature/sdk to 2.3.0 and updates associated lock metadata.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@jonathannorris
jonathannorris merged commit 0a162d7 into main Aug 6, 2026
6 of 7 checks passed
@jonathannorris
jonathannorris deleted the chore/of-sdk-bump branch August 6, 2026 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants