fix(license): Fix old license bit issue#34278
Merged
ajivanyandev merged 5 commits intoJul 15, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates DevExtreme’s internal license validation to support legacy/incorrect LCP product keys that contain only the DevExtreme ASP.NET product bit, enabling compatibility only when an ASP.NET-related version assertion is present.
Changes:
- Adds an “ASP.NET compatibility” gate based on
versionAssertionsand threads it throughparseLicenseKey→parseDevExpressProductKey. - Extends LCP key parsing to optionally treat
DevExtremeAspNetas acceptable for computingmaxVersionAllowed. - Adds Jest coverage for the new compatibility gate and the ASP.NET-only product-bit scenario.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| packages/devextreme/js/__internal/core/license/license_validation.ts | Detects ASP.NET assertions and conditionally enables ASP.NET product-bit compatibility during license parsing. |
| packages/devextreme/js/__internal/core/license/license_validation.test.ts | Adds tests ensuring the compatibility flag is passed only when ASP.NET assertions exist. |
| packages/devextreme/js/__internal/core/license/lcp_key_validation/license_info.ts | Adds a helper to find the latest version when ASP.NET product compatibility is enabled. |
| packages/devextreme/js/__internal/core/license/lcp_key_validation/lcp_key_validator.ts | Extends product-key parsing with an optional ASP.NET compatibility parameter and uses the new helper. |
| packages/devextreme/js/__internal/core/license/lcp_key_validation/lcp_key_validation.test.ts | Adds tests verifying ASP.NET-only product bits are rejected by default and accepted in compatibility mode. |
AlisherAmonulloev
approved these changes
Jul 15, 2026
GoodDayForSurf
approved these changes
Jul 15, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.