Skip to content

Gulp: localization generate-community-locales gulp task move to nx ex…#34286

Merged
vorobey merged 4 commits into
DevExpress:feature/gulp-to-nx-migrationfrom
vorobey:feature/gulp-to-nx-generate-community-locales
Jul 14, 2026
Merged

Gulp: localization generate-community-locales gulp task move to nx ex…#34286
vorobey merged 4 commits into
DevExpress:feature/gulp-to-nx-migrationfrom
vorobey:feature/gulp-to-nx-generate-community-locales

Conversation

@vorobey

@vorobey vorobey commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@vorobey vorobey self-assigned this Jul 13, 2026
@vorobey
vorobey requested a review from Copilot July 13, 2026 15:08
@vorobey
vorobey marked this pull request as ready for review July 13, 2026 15:08

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Migrates the generate-community-locales gulp task into an Nx executor within nx-infra-plugin, and wires the DevExtreme package/build scripts to invoke the new target for in-place normalization of community locale message files.

Changes:

  • Added a new devextreme-nx-infra-plugin:generate-community-locales executor (schema, implementation, and e2e tests).
  • Registered the executor in packages/nx-infra-plugin/executors.json and documented the migration in AGENTS.md.
  • Switched DevExtreme’s build:community-localization to an Nx target and updated the gulp task + package script to delegate to it.

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
packages/nx-infra-plugin/src/executors/generate-community-locales/schema.ts Adds TypeScript options interface for the new executor.
packages/nx-infra-plugin/src/executors/generate-community-locales/schema.json Defines Nx schema (defaults + option descriptions) for executor configuration.
packages/nx-infra-plugin/src/executors/generate-community-locales/generate-community-locales.impl.ts Implements locale file normalization logic (template from default locale, fill translations, keep formatting).
packages/nx-infra-plugin/src/executors/generate-community-locales/executor.ts Exposes the executor entrypoint for Nx.
packages/nx-infra-plugin/src/executors/generate-community-locales/executor.e2e.spec.ts Adds e2e coverage validating normalization behavior and failure mode.
packages/nx-infra-plugin/executors.json Registers the new executor in the plugin.
packages/nx-infra-plugin/AGENTS.md Documents the gulp→Nx migration mapping and operational details for the new target.
packages/devextreme/project.json Adds build:community-localization target using the new executor (non-cached, in-place).
packages/devextreme/package.json Updates build:community-localization script to call Nx target directly.
packages/devextreme/build/gulp/localization.js Replaces gulp-stream implementation with a shell delegation to the Nx target.

Copilot AI review requested due to automatic review settings July 13, 2026 15:12

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.

Copilot AI review requested due to automatic review settings July 14, 2026 06:33
@vorobey
vorobey requested a review from a team July 14, 2026 06:33

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 10 out of 10 changed files in this pull request and generated no new comments.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 10 out of 10 changed files in this pull request and generated no new comments.

@vorobey
vorobey changed the base branch from main to feature/gulp-to-nx-migration July 14, 2026 09:56
Andrei Vorobev and others added 4 commits July 14, 2026 17:08
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Andrey Vorobev <dobriy.kaa@gmail.com>
@vorobey
vorobey force-pushed the feature/gulp-to-nx-generate-community-locales branch from 49000a8 to 785907f Compare July 14, 2026 14:09
@vorobey
vorobey merged commit c7bb4ab into DevExpress:feature/gulp-to-nx-migration Jul 14, 2026
133 of 140 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants