DataGrid - AI Assistant: set fixed default popup height#34289
Merged
Alyar666 merged 4 commits intoJul 15, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Sets a fixed default height for the DataGrid AI Assistant popup (instead of computing it from the grid layout), and adds an integration test to validate the default and overridden heights.
Changes:
- Introduced
AI_ASSISTANT_POPUP_HEIGHTconstant (560) for the default popup height. - Updated
AIAssistantViewto use the fixed default height while still allowingaiAssistant.popupoverrides. - Added an integration test verifying the default height and a custom
aiAssistant.popup.heightvalue; extended the AI chat test model with popup height helpers.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/devextreme/js/__internal/grids/grid_core/ai_assistant/const.ts | Adds a shared constant for the default AI Assistant popup height. |
| packages/devextreme/js/__internal/grids/grid_core/ai_assistant/ai_assistant_view.ts | Switches popup height from dynamic calculation to a fixed default height. |
| packages/devextreme/js/__internal/grids/grid_core/ai_assistant/tests/ai_assistant_view.integration.test.ts | Adds integration coverage for default and overridden popup heights. |
| packages/devextreme/js/__internal/grids/grid_core/tests/mock/model/ai_chat.ts | Adds helpers to locate popup content and read its height for tests. |
anna-shakhova
requested changes
Jul 14, 2026
anna-shakhova
previously approved these changes
Jul 14, 2026
Alyar666
force-pushed
the
datagrid_ai_assistant_add_default_height_26_2
branch
from
July 14, 2026 16:24
4f614d4 to
6bf1c1d
Compare
anna-shakhova
approved these changes
Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.