Grids - DataController: Refactoring the _partialUpdateRow method - #34926
Open
Alyar666 wants to merge 3 commits into
Open
Grids - DataController: Refactoring the _partialUpdateRow method#34926Alyar666 wants to merge 3 commits into
Alyar666 wants to merge 3 commits into
Conversation
Alyar666
changed the title
Alyar666
marked this pull request as ready for review
August 26, 2026 09:58
Contributor
There was a problem hiding this comment.
Pull request overview
Refactors DataController’s partial row update logic in the grid core to extract reusable helpers into row_changes.ts and standardize the extension hook for computing changed column indices.
Changes:
- Renamed the extensibility hook from
_getChangedColumnIndicestogetChangedColumnIndicesacross DataController and editing extenders. - Extracted partial-update helpers (
canDiffColumns,getGroupColumnIndices,getPartialUpdateColumnIndices,partialUpdateRow) intodata_controller/utils/row_changes.ts. - Added Jest coverage for the newly extracted helper functions.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packages/devextreme/js/__internal/grids/grid_core/editing/extenders/editing_row_based_data_controller.ts | Updates the override to the renamed getChangedColumnIndices hook and delegates to the base implementation. |
| packages/devextreme/js/__internal/grids/grid_core/editing/extenders/editing_form_based_data_controller.ts | Updates the override to the renamed getChangedColumnIndices hook and keeps the form-edit-mode conditional behavior. |
| packages/devextreme/js/__internal/grids/grid_core/editing/extenders/editing_data_controller.ts | Updates the override to the renamed getChangedColumnIndices hook while preserving editing-specific diff constraints. |
| packages/devextreme/js/__internal/grids/grid_core/data_controller/utils/row_changes.ts | Introduces extracted helpers for column diff eligibility, group-row indices selection, and partial row update application. |
| packages/devextreme/js/__internal/grids/grid_core/data_controller/utils/tests/row_changes.test.ts | Adds unit tests validating the behavior of the new helper functions. |
| packages/devextreme/js/__internal/grids/grid_core/data_controller/data_controller.ts | Rewires partial update flow to use the extracted helpers and the renamed getChangedColumnIndices hook. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
anna-shakhova
requested changes
Aug 26, 2026
|
|
||
| if (newItem.rowType === 'groupFooter') { | ||
| return undefined; | ||
| switch (newItem.rowType) { |
Contributor
There was a problem hiding this comment.
group, detail, groupFooter are not belong to base controller and should be moved to corresponding extender, better keep old logic here and create separate PR for move
Alyar666
force-pushed
the
gridcore_datacontroller__extract_row_diffing_engine_26_2
branch
from
August 28, 2026 09:28
fb5b531 to
3ac00c9
Compare
anna-shakhova
approved these changes
Aug 28, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Aug 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.