Test CI - #34954
Open
EugeniyKiyashko wants to merge 3 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the TestCafe CI workflow to allow style-dependent tests to be included even when style files haven’t changed, by honoring a PR label override. This improves CI flexibility for cases where a full test sweep is needed without modifying style paths.
Changes:
- Extend
styles-changedjob output to becometruewhen either style-related paths change or the PR has theforce all testslabel.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
Suppressed comments (1)
Previously missed (1) — in code that hasn't changed since the last review.
.github/workflows/testcafe_tests.yml:24
- The
styles-changedjob output now referencesgithub.event.pull_request.labels, but this workflow also runs onmerge_groupandworkflow_dispatchevents wheregithub.event.pull_requestmay be undefined, which can cause expression evaluation failures. Guard the label check withgithub.event_name == 'pull_request'(or similar) so non-PR runs don’t break.
styles-changed: ${{ steps.changes.outputs.styles == 'true' || contains(github.event.pull_request.labels.*.name, 'force all tests') }}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.