Skip to content

Core(Events): remove m_ prefix from the pointer observer & address review notes - #34978

Open
EugeniyKiyashko wants to merge 2 commits into
mainfrom
typescript/events/observer_cleanup
Open

Core(Events): remove m_ prefix from the pointer observer & address review notes#34978
EugeniyKiyashko wants to merge 2 commits into
mainfrom
typescript/events/observer_cleanup

Conversation

@EugeniyKiyashko

Copy link
Copy Markdown
Contributor

No description provided.

Copilot AI lite review requested due to automatic review settings August 28, 2026 18:50

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates DevExtreme’s internal pointer event infrastructure by renaming the pointer observer module to remove the legacy m_ prefix, and applies a small set of related refactors/cleanup notes in pointer strategies and keyboard processing.

Changes:

  • Switched pointer observer re-exports/imports from m_observer to observer.
  • Renamed the internal pointer strategy event-args type from PointerEventInit to PointerStrategyEventArgs and updated strategy implementations accordingly.
  • Refactored KeyboardProcessor to use module-level namespaced event constants and to safely accept undefined/null options.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.

Show a summary per file
File Description
packages/devextreme/js/common/core/events/pointer/observer.js Re-export updated to point to the renamed internal observer module.
packages/devextreme/js/__internal/events/pointer/observer.ts Keeps observer implementation; minor default-callback cleanup.
packages/devextreme/js/__internal/events/pointer/base.ts Renames pointer strategy args type; simplifies remove() logic.
packages/devextreme/js/__internal/events/pointer/mouse.ts Updates imports/types to reference observer and new args type.
packages/devextreme/js/__internal/events/pointer/touch.ts Updates imports/types to new args type and observer type export.
packages/devextreme/js/__internal/events/pointer/mouse_and_touch.ts Updates imports/types to new args type and observer type export.
packages/devextreme/js/__internal/events/core/keyboard_processor.ts Uses module-level namespaced event strings; constructor now tolerates null/undefined options.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants