Core(Events): remove m_ prefix from the pointer observer & address review notes - #34978
Open
EugeniyKiyashko wants to merge 2 commits into
Open
Core(Events): remove m_ prefix from the pointer observer & address review notes#34978EugeniyKiyashko wants to merge 2 commits into
EugeniyKiyashko wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates DevExtreme’s internal pointer event infrastructure by renaming the pointer observer module to remove the legacy m_ prefix, and applies a small set of related refactors/cleanup notes in pointer strategies and keyboard processing.
Changes:
- Switched pointer observer re-exports/imports from
m_observertoobserver. - Renamed the internal pointer strategy event-args type from
PointerEventInittoPointerStrategyEventArgsand updated strategy implementations accordingly. - Refactored
KeyboardProcessorto use module-level namespaced event constants and to safely acceptundefined/nulloptions.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packages/devextreme/js/common/core/events/pointer/observer.js | Re-export updated to point to the renamed internal observer module. |
| packages/devextreme/js/__internal/events/pointer/observer.ts | Keeps observer implementation; minor default-callback cleanup. |
| packages/devextreme/js/__internal/events/pointer/base.ts | Renames pointer strategy args type; simplifies remove() logic. |
| packages/devextreme/js/__internal/events/pointer/mouse.ts | Updates imports/types to reference observer and new args type. |
| packages/devextreme/js/__internal/events/pointer/touch.ts | Updates imports/types to new args type and observer type export. |
| packages/devextreme/js/__internal/events/pointer/mouse_and_touch.ts | Updates imports/types to new args type and observer type export. |
| packages/devextreme/js/__internal/events/core/keyboard_processor.ts | Uses module-level namespaced event strings; constructor now tolerates null/undefined options. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.