Chained scan unit test - #287
Open
keptsecret wants to merge 9 commits into
Open
Conversation
…s in scan, memory barrier (might be unnecessary
|
|
||
| struct device_capabilities | ||
| { | ||
| #ifdef TEST_NATIVE |
Contributor
There was a problem hiding this comment.
small nitpicking: If you do { "TEST_NATIVE", "1" } to enable this, it should be #if not #ifdef
| // Normally we'd beautifully JSON serialize the thing, allow multiple devices & drivers + metadata | ||
| auto bin = cpu->getEntries().begin()->second.bin; | ||
| IFile::success_t success; | ||
| m_spirv_isa_cache_output->write(success, bin->data(), 0ull, bin->size()); |
Contributor
There was a problem hiding this comment.
I can't seem to get the purpose or benefit of the pipeline cache in this example it looks completely unnecessary.
It gets constantly overwritten
and you could actually create a single pipeline per workgroup conf at runtime and not any sort of pipeline cache.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.