ENG-2111 Add keyboard-only node type filtering with tag chips

[trangdoan982]

https://www.loom.com/share/7eae3997668c43829896b093d005401a

What this does

Chips and the query caret now share one field, so a keyboard-first user can narrow by type without reaching for the mouse. Typing offers the best prefix match as ghost text with a ⇥ hint; Tab commits it to a chip. Text left unconfirmed stays a plain keyword query, so filtering never happens by accident.

Roam's advanced search is the design and behaviour reference. Obsidian has no tag-input component at all, so this is a build rather than a port.

Notable decisions

• State is ENG-2110's. selectedNodeTypeIds stays the single source of truth, so chips and the filter dropdown are two views of one state. No change to QueryEngine. The chips write the raw list and skip fromPanelSelectedIds' canonicalisation on purpose: collapsing a full selection to "no filter" would make a chip the user just added vanish.
• Keys bubble instead of being forwarded. Arrow, Enter and Escape reach NodeSearch, whose handler is already an ancestor and already navigates and opens results. Roam threads them through an onSearchKeyDown prop; here that would only duplicate it.
• Backspace highlights before it deletes. The ticket said "removes the most recent chip"; this follows Roam instead, so a stray keystroke cannot silently drop a filter. The chip-focus state it needs is the same state the arrow keys use.
• Matching is prefix-only. The suggestion is drawn as a completion of what was typed, and a substring match has no suffix to render.
• The Tab hint shows whenever Tab would commit — including once the query spells a type name in full and no suffix is left to ghost. Roam hides it there, which is exactly when the user is about to press it.
• The query is a textarea that grows with its content, so a long query and many chips stay visible rather than scrolling out of the field. Modified Enter is suppressed there: the modal deliberately leaves Mod/Ctrl/Alt+Enter unhandled for the insert and dock actions, so the query would otherwise gain a line break.
• Field chrome comes from Obsidian's own input variables rather than Tailwind tokens, so it matches a native field (border, --background-modifier-form-field, --input-radius). Two rules were dropped as dead: --input-shadow is none in Obsidian 1.13 and --input-shadow-active is undefined — native fields there are marked by border colour alone.
• Tailwind's ring-* utilities are inert in this build. --tw-ring-shadow and its offset counterpart are never defined, so the composite box-shadow collapses to none and a focused chip rendered no state at all. The focused chip takes an outline in CSS instead — no variables needed, and unlike a border it does not shift the chips beside it as focus moves.
• Chip remove buttons are tabIndex={-1}. Tab is the commit key, so focusable remove buttons would wedge themselves into the tab order ahead of the footer actions; keyboard users delete via the highlighted chip.

Known edge case, documented rather than fixed

Chipping every configured type makes selectedNodeTypeIds.length === allTypeIds.length, which hasActiveTypeFilter reads as "no filter" — the count badge disappears while the chips stay on screen. Results are identical either way, and the dropdown shows all rows checked, so the two surfaces do not disagree. Suppressing the last chip would be worse: it would silently refuse a type the user asked for.

Verification

• pnpm check-types and pnpm lint clean in apps/obsidian (0 errors; pre-existing warnings elsewhere untouched).
• 32/32 assertions driving the running Obsidian over CDP against a test vault, re-run after the rebase: ghost completion, Tab commit, immediate narrowing, two-chip union, unconfirmed text applying no filter, Backspace highlight-then-remove with the marking asserted on the rendered outline, arrow navigation across chips and back to the caret, results navigation with a chip focused, modified Enter inserting no newline, Tab fall-through to the filter trigger, field growth without clipping, and chip↔dropdown sync in both directions.
• Field geometry measured: an empty field is 34px like a native input; a long query grows it 34→53px alone and 34→92px with five chips, nothing clipped; all ten types chipped keeps every chip visible.
• No unit tests. apps/obsidian has no test harness — no test script, no vitest config, no test files — the same call ENG-2110 made. The matching rules were split into a pure util so they are ready for one.

🤖 Generated with Claude Code

---

[linear-code]

ENG-2111

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated (UTC)
discourse-graph	Skipped		Aug 22, 2026 4:49am

[graphite-app]

PR size/scope check

This PR is over our review-size guideline.

• Recommended: ~200 lines changed
• Acceptable limit: up to 400 lines when well-scoped/self-contained
• Preferred file count: fewer than 5 files

Please split this into smaller PRs unless there is a clear reason the changes need to land together.

If keeping it as one PR, please add a brief justification covering:

• What single problem this PR solves
• Why the files/changes are coupled

[supabase]

This pull request has been ignored for the connected project zytfjzqyijgagqxrzbmz because there are no changes detected in packages/database/supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.

---

Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

[devin-ai-integration]

Devin Review found 3 potential issues.

View 1 additional finding in Devin Review.