Skip to content

Support URL and roam.js prototype loading - #15

Merged
mdroidian merged 7 commits into
mainfrom
agent/support-url-and-roam-js-loading
Aug 21, 2026
Merged

Support URL and roam.js prototype loading#15
mdroidian merged 7 commits into
mainfrom
agent/support-url-and-roam-js-loading

Conversation

@mdroidian

Copy link
Copy Markdown
Member

Summary

  • document URL loading and roam/js loading as supported prototype modes
  • add a generated roam/js loader that cache-busts imports, validates before replacement, unloads the previous copy, and manages extension.css
  • make the generated lifecycle callback and Loaded Dialog report failures safely when extensionAPI is unavailable
  • smoke-test generated artifacts with both a Roam-supplied extension API and extensionAPI: undefined

Loading contract

  • URL: Roam supplies extensionAPI, manages extension.css, and owns unloading.
  • roam/js: the loader imports the same ESM artifact, passes extensionAPI: undefined, and manages CSS and replacement unloading. Global window.roamAlphaAPI remains available.

This PR is stacked on #14 so the loader support lands after the shared ESM/CommonJS interop guard.

Validation

  • pnpm test
  • pnpm build
  • pnpm prepare:artifacts

@mdroidian
mdroidian marked this pull request as ready for review August 21, 2026 04:33

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 26b796e866

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread packages/extension-base/template/README.md Outdated

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Open in Devin Review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: facdaa8834

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread packages/extension-base/template/README.md

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 7ec0b78ed2

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread packages/extension-base/template/src/index.ts

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 452b8da891

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread packages/extension-base/template/README.md
Base automatically changed from agent/prevent-roamjs-default-imports to main August 21, 2026 05:12
@mdroidian
mdroidian merged commit c820b5d into main Aug 21, 2026
1 check passed
@mdroidian
mdroidian deleted the agent/support-url-and-roam-js-loading branch August 21, 2026 05:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant