Add custom CMOR table and derivation script for permafrost - #2358
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2358 +/- ##
==========================================
+ Coverage 95.59% 95.61% +0.01%
==========================================
Files 266 267 +1
Lines 15573 15629 +56
==========================================
+ Hits 14887 14943 +56
Misses 686 686 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
In order to maintain a backlog of relevant pull requests, we automatically label them as stale after 180 days of inactivity. If this pull request is still important to you, please comment below to remove the stale label. Otherwise, this pull request will be automatically closed in 60 days. If this pull request only suffers from a lack of reviewers, please tag the @ESMValGroup/technical-lead-development-team so they can help you find a suitable reviewer. |
bouweandela
left a comment
There was a problem hiding this comment.
It looks like there is also a derivation function in this pull request that is not mentioned in the description at the top. Is that intentional? If yes, please make sure that the derivation is lazy and add a unit test for it.
Co-authored-by: Bouwe Andela <b.andela@esciencecenter.nl>
|
If you click the |
|
Hello, this pull request has been marked with the If you won't be able to finish this in time, don't worry - just unassign the milestone |
Co-authored-by: Bouwe Andela <b.andela@esciencecenter.nl>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2358 +/- ##
=======================================
Coverage 96.49% 96.50%
=======================================
Files 280 281 +1
Lines 16282 16348 +66
=======================================
+ Hits 15711 15776 +65
- Misses 571 572 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Sorry, it looks like we cannot reach a consensus on this in time for v2.14.0. Moving this to v2.15.0, please let me know if this causes any troubles. |
|
Hi all, as we prepare for the ESMValCore v2.15.0 release, the planned code freeze is 19 June 2026. This PR is currently marked for the v2.15.0 milestone. Could you please confirm whether it should remain in scope for this release, or whether it would be better moved to a later milestone? @flicj191 tagging you for release-freeze awareness. |
|
Hi all, sorry this couldn't be completed for 2.15, I will move this to 2.16. Let me know any issues. |
|
I think all comments are now addressed and this PR would be ready for merging. |
|
Could you take a look at the output of |
… into esacci-permafrost
|
Thanks @bouweandela ! I fixed the issues found by pre-commit here: 3ea1cbd @LisaBock it would be fantastic if you could do a scientific review... |
|
@LisaBock Just in case, here is a recipe that could be used for testing: https://github.com/ESMValGroup/ESMValTool/blob/cmug_test_recipes/esmvaltool/recipes/esa/recipe_pfr_test.yml |
LisaBock
left a comment
There was a problem hiding this comment.
Thanks @axel-lauer ! The run with the test recipe was successful and the results looks fine to me.
|
Thanks all! |
Description
This PR adds (a) custom CMOR tables for the following three ESACCI-PERMAFROST variables:
and (b) a derivation script for permafrost extent (pfr) to calculate this variable from the CMIP models.
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.
- [ ] 🧪 and 🛠 Documentation is available- [ ] 🛠 Any changed dependencies have been added or removed correctly- [ ] 🛠 The list of authors is up to date