Skip to content

Add custom CMOR table and derivation script for permafrost - #2358

Merged
schlunma merged 36 commits into
mainfrom
esacci-permafrost
Aug 24, 2026
Merged

Add custom CMOR table and derivation script for permafrost#2358
schlunma merged 36 commits into
mainfrom
esacci-permafrost

Conversation

@axel-lauer

@axel-lauer axel-lauer commented Mar 4, 2024

Copy link
Copy Markdown
Contributor

Description

This PR adds (a) custom CMOR tables for the following three ESACCI-PERMAFROST variables:

  • active layer thickness (alt)
  • permafrost ground temperature (gtd)
  • permafrost extent (pfr)

and (b) a derivation script for permafrost extent (pfr) to calculate this variable from the CMIP models.

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.

@axel-lauer axel-lauer added cmor Related to the CMOR standard observations labels Mar 4, 2024
@codecov

codecov Bot commented Mar 4, 2024

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.61%. Comparing base (9244717) to head (c5453bb).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2358      +/-   ##
==========================================
+ Coverage   95.59%   95.61%   +0.01%     
==========================================
  Files         266      267       +1     
  Lines       15573    15629      +56     
==========================================
+ Hits        14887    14943      +56     
  Misses        686      686              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@axel-lauer axel-lauer changed the title Add custom CMO tables for ESACCI-PERMAFROST Add custom CMOR tables for ESACCI-PERMAFROST Mar 4, 2024
@github-actions

Copy link
Copy Markdown
Contributor

In order to maintain a backlog of relevant pull requests, we automatically label them as stale after 180 days of inactivity.

If this pull request is still important to you, please comment below to remove the stale label. Otherwise, this pull request will be automatically closed in 60 days. If this pull request only suffers from a lack of reviewers, please tag the @ESMValGroup/technical-lead-development-team so they can help you find a suitable reviewer.

@github-actions github-actions Bot added the Stale label Jun 27, 2025
@github-actions github-actions Bot removed the Stale label Jul 24, 2025
@axel-lauer
axel-lauer marked this pull request as ready for review July 25, 2025 11:19

@bouweandela bouweandela left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like there is also a derivation function in this pull request that is not mentioned in the description at the top. Is that intentional? If yes, please make sure that the derivation is lazy and add a unit test for it.

Comment thread esmvalcore/preprocessor/_derive/pfr.py Outdated
@axel-lauer axel-lauer changed the title Add custom CMOR tables for ESACCI-PERMAFROST Add custom CMOR table and derivation script for permafrost Jan 9, 2026
@axel-lauer axel-lauer added this to the v2.14.0 milestone Jan 12, 2026
Comment thread esmvalcore/preprocessor/_derive/pfr.py Outdated
@bouweandela

Copy link
Copy Markdown
Member

If you click the Update branch button or run git pull origin main --no-ff and git push locally, the tests on CircleCI should run again.

@schlunma

Copy link
Copy Markdown
Contributor

Hello, this pull request has been marked with the v2.14.0 milestone. The release of version 2.14.0 is currently scheduled for February 2026. To get this into the new release, it would be great to get this merged by the end of January.

If you won't be able to finish this in time, don't worry - just unassign the milestone v2.14.0. If you need any support, ping myself (@schlunma; the release manager for v2.14.0) or the @ESMValGroup/technical-lead-development-team. Please note that I won't be available until the beginning of February, though.

Comment thread esmvalcore/preprocessor/_derive/pfr.py Outdated
Co-authored-by: Bouwe Andela <b.andela@esciencecenter.nl>
@codecov

codecov Bot commented Jan 22, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.50%. Comparing base (539fe90) to head (75c7398).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2358   +/-   ##
=======================================
  Coverage   96.49%   96.50%           
=======================================
  Files         280      281    +1     
  Lines       16282    16348   +66     
=======================================
+ Hits        15711    15776   +65     
- Misses        571      572    +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@schlunma

schlunma commented Feb 4, 2026

Copy link
Copy Markdown
Contributor

Sorry, it looks like we cannot reach a consensus on this in time for v2.14.0. Moving this to v2.15.0, please let me know if this causes any troubles.

@schlunma schlunma modified the milestones: v2.14.0, v2.15.0 Feb 4, 2026
@rbeucher

Copy link
Copy Markdown
Contributor

Hi all, as we prepare for the ESMValCore v2.15.0 release, the planned code freeze is 19 June 2026.

This PR is currently marked for the v2.15.0 milestone. Could you please confirm whether it should remain in scope for this release, or whether it would be better moved to a later milestone?

@flicj191 tagging you for release-freeze awareness.

@flicj191

Copy link
Copy Markdown
Contributor

Hi all, sorry this couldn't be completed for 2.15, I will move this to 2.16. Let me know any issues.

@flicj191 flicj191 modified the milestones: v2.15.0, v2.16.0 Jun 21, 2026
@axel-lauer

Copy link
Copy Markdown
Contributor Author

I think all comments are now addressed and this PR would be ready for merging.

@bouweandela

bouweandela commented Aug 19, 2026

Copy link
Copy Markdown
Member

Could you take a look at the output of pre-commit run -a please? There appear to be a few formatting and spelling issues. Technically, this looks good to me now, but it would need a scientific review as the algorithm is non-trivial.

@axel-lauer
axel-lauer requested a review from LisaBock August 19, 2026 10:26
@axel-lauer

Copy link
Copy Markdown
Contributor Author

Thanks @bouweandela ! I fixed the issues found by pre-commit here: 3ea1cbd

@LisaBock it would be fantastic if you could do a scientific review...

@axel-lauer

Copy link
Copy Markdown
Contributor Author

@LisaBock Just in case, here is a recipe that could be used for testing: https://github.com/ESMValGroup/ESMValTool/blob/cmug_test_recipes/esmvaltool/recipes/esa/recipe_pfr_test.yml

@LisaBock LisaBock left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @axel-lauer ! The run with the test recipe was successful and the results looks fine to me.

@schlunma

Copy link
Copy Markdown
Contributor

Thanks all!

@schlunma
schlunma merged commit 936450c into main Aug 24, 2026
6 checks passed
@schlunma
schlunma deleted the esacci-permafrost branch August 24, 2026 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cmor Related to the CMOR standard observations

Projects

No open projects

Development

Successfully merging this pull request may close these issues.

6 participants