Remove reference to wandb's removed RunDisabled class - #781
Open
dmitryduev wants to merge 1 commit into
Open
Conversation
8 tasks
dmitryduev
marked this pull request as ready for review
August 26, 2026 07:06
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
wandb deprecated
RunDisabledin v0.17.6 (wandb/wandb#8064): since then,wandb.init(mode="disabled")returns a regular no-opwandb.Run, andRunDisabledhas been an empty compatibility shim that emits a deprecation warning on attribute access. The shim is being removed in an upcoming wandb release (wandb/wandb#12586), after which importing it raisesImportError.This PR drops the remaining references so the integration keeps working with upcoming wandb releases, while remaining compatible with older ones.
Details:
skll/utils/wandb.pyimportsRunDisabledat module level, which would raiseImportErrorunder the upcoming wandb release. TheOptional[Union[Run, RunDisabled]]hint is narrowed toOptional[Run]and the now-unusedUnionimport is dropped; behavior unchanged.