Skip to content

tests: fix flaky test_onchain_rbf_stops_after_confirmation #9348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ksedgwic wants to merge 1 commit into
base: master
Choose a base branch
from
+9 −2
Open

tests: fix flaky test_onchain_rbf_stops_after_confirmation #9348

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions tests/test_closing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1765,8 +1765,15 @@ def censoring_sendrawtx(r):
bitcoind.generate_block(1)
l2.daemon.wait_for_log('RBF onchain txid')

# Stop censoring. Generate a block to trigger rebroadcast (the penalty tx
# enters bitcoind's mempool) but filter it out so the next block mines it.
# Stop censoring — but only once all four censored broadcasts (initial
# penalty tx plus three replacements) have reached the proxy: each 'RBF
# onchain txid' log line precedes the corresponding broadcast, and
# un-mocking while one is in flight lets an old version into bitcoind's
# real mempool, where it gets mined in place of the version the node
# tracks (#9347). The proxy counts the calls its mock swallows.
# Then generate a block to trigger rebroadcast (the penalty tx enters
# bitcoind's mempool) but filter it out so the next block mines it.
wait_for(lambda: l2.daemon.rpcproxy.mock_counts['sendrawtransaction'] >= 4)
l2.daemon.rpcproxy.mock_rpc('sendrawtransaction', None)
bitcoind.generate_block(1, needfeerate=10000000)
l2.daemon.wait_for_log('RBF onchain txid')
Expand Down
Loading