Skip to content

Split developer persistence by workflow - #188

Merged
admdly merged 8 commits into
mainfrom
agent/split-developer-persistence
Aug 6, 2026
Merged

Split developer persistence by workflow#188
admdly merged 8 commits into
mainfrom
agent/split-developer-persistence

Conversation

@admdly

@admdly admdly commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Replace the 1,883-line DevelopersDatabase with cohesive profile, transfer, and claim database classes.
  • Extract shared GitHub ownership verification into developer-identity-verification.ts.
  • Update route wiring, the shared owner-conflict classifier, and stale class references.

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Aug 6, 2026

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
api 2030b9d Commit Preview URL

Branch Preview URL
Aug 06 2026, 02:59 PM

@admdly admdly self-assigned this Aug 6, 2026
@admdly
admdly marked this pull request as ready for review August 6, 2026 08:51

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 15 files

Reply with feedback, questions, or to request a fix.

Re-trigger cubic

Comment thread src/services/extensions/v2/developer-transfers-database.ts Outdated
Comment thread src/services/extensions/v2/developer-profiles-database.ts
Comment thread src/services/extensions/v2/developer-identity-verification.ts Outdated
Comment thread src/services/extensions/v2/developer-claims-database.ts Outdated
Comment thread src/services/extensions/v2/developer-identity-verification.ts
Comment thread src/services/extensions/v2/developer-transfers-database.ts
@admdly
admdly marked this pull request as draft August 6, 2026 09:18
@admdly
admdly marked this pull request as ready for review August 6, 2026 09:21

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 8 files (changes from recent commits).

Reply with feedback, questions, or to request a fix.

Re-trigger cubic

Comment thread src/services/extensions/v2/users-database.ts

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 15 files

Reply with feedback, questions, or to request a fix.

Re-trigger cubic

Comment thread src/services/extensions/v2/developer-transfers-database.ts
Comment thread test/services/extensions/v2/index.test.ts Outdated
Comment thread src/services/extensions/v2/developer-profiles-database.ts Outdated
Comment thread src/services/extensions/v2/developer-profiles-database.ts
Comment thread src/services/extensions/v2/developer-profiles-database.ts Outdated
@admdly
admdly marked this pull request as draft August 6, 2026 10:08

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0 issues found across 6 files (changes from recent commits).

Requires human review: Auto-approval blocked by 2 unresolved issues from previous reviews.

Re-trigger cubic

@admdly
admdly marked this pull request as ready for review August 6, 2026 12:00

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 16 files

Reply with feedback, questions, or to request a fix.

Re-trigger cubic

Comment thread src/services/extensions/v2/developer-profiles-database.ts
Comment thread src/services/extensions/v2/users-database.ts
Comment thread src/services/extensions/v2/developer-transfers-database.ts Outdated
Comment thread src/services/extensions/v2/developer-profiles-database.ts
Comment thread src/services/extensions/v2/developer-profiles-database.ts Outdated
Comment thread src/services/extensions/v2/developer-profiles-database.ts
@admdly
admdly marked this pull request as draft August 6, 2026 12:42
@admdly
admdly marked this pull request as ready for review August 6, 2026 12:47

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 6 files (changes from recent commits).

Tip: Review your code locally with the cubic CLI to iterate faster.

Re-trigger cubic

Comment thread src/services/extensions/v2/users-database.ts Outdated
@admdly
admdly marked this pull request as draft August 6, 2026 13:00
cubic-dev-ai[bot]
cubic-dev-ai Bot previously approved these changes Aug 6, 2026

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0 issues found across 2 files (changes from recent commits).

Auto-approved: Refactor splitting a monolithic database class into cohesive profile, claim, and transfer classes, with focused bug fixes for inactive-account handling, date validation, and whitespace logins. No schema, route, or contract changes; new tests verify the corrected behavior.

Re-trigger cubic

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed

Reply with feedback, questions, or to request a fix.

Re-trigger cubic

Comment thread src/services/extensions/v2/developer-profiles-database.ts
Comment thread src/services/extensions/v2/developer-profiles-database.ts
@cubic-dev-ai
cubic-dev-ai Bot dismissed their stale review August 6, 2026 13:09

Dismissed because Cubic found issues in a newer review.

@admdly
admdly marked this pull request as ready for review August 6, 2026 13:36

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 16 files

Requires human review: The PR mixes a refactor with a verification-policy change: missing/malformed GitHub membership evidence now falls back to unverified manual review instead of returning 403 GITHUB_MISMATCH. A human should approve this ownership-verification security tradeoff before merging.

Re-trigger cubic

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0 issues found across 6 files (changes from recent commits).

Requires human review: This PR changes ownership verification: missing/expired GitHub membership evidence falls back to unverified/manual review, and inactive accounts trigger ACCOUNT_INACTIVE. A human should approve this tradeoff.

Re-trigger cubic

@admdly
admdly merged commit 24192d0 into main Aug 6, 2026
9 checks passed
@admdly
admdly deleted the agent/split-developer-persistence branch August 6, 2026 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant