Skip to content

feat: ClickHouse warehouse setup UI behind clickhouse_warehouse flag#8028

Draft
Zaimwa9 wants to merge 6 commits into
feat/clickhouse-byo-warehouse-backendfrom
feat/clickhouse-byo-warehouse-frontend
Draft

feat: ClickHouse warehouse setup UI behind clickhouse_warehouse flag#8028
Zaimwa9 wants to merge 6 commits into
feat/clickhouse-byo-warehouse-backendfrom
feat/clickhouse-byo-warehouse-frontend

Conversation

@Zaimwa9

@Zaimwa9 Zaimwa9 commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Thanks for submitting a PR! Please check the boxes below:

  • I have read the Contributing Guide.
  • I have added information to docs/ if required so people know about the feature.
  • I have filled in the "Changes" section below.
  • I have filled in the "How did you test this code" section below.

Changes

Frontend for the clickhouse warehouse connection type, gated behind the clickhouse_warehouse flag (off by default). Builds on the backend in #8020.

  • New ClickHouse config form, visually identical to the Snowflake one: host, name, port, database, username, password and a TLS toggle, with defaults matching the backend. The host is locked when editing; leaving the password blank on edit keeps the stored credentials.
  • The warehouse setup flow offers ClickHouse alongside Flagsmith and Snowflake when the flag is enabled.
  • The connection card wires the Test connection button for ClickHouse and surfaces the new status_detail field: the status tooltip shows the failure reason when the connection is errored, and the test-connection toast reports it instead of a generic message.
  • API layer types updated: write-only credentials, read-only status_detail.

How did you test this code?

Unit tests for the form validation and payload helpers (npm run test:unit -- --testPathPatterns=clickhouseConfig), npm run lint, npm run typecheck (no new errors against the baseline).

Manually: enable the clickhouse_warehouse flag, go to Environment Settings → Warehouse, connect a ClickHouse instance, then edit it and use Test connection to see verification results, including failure reasons.

@vercel

vercel Bot commented Jul 16, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
flagsmith-frontend-preview Ready Ready Preview, Comment Jul 16, 2026 10:50am
flagsmith-frontend-staging Ready Ready Preview, Comment Jul 16, 2026 10:50am
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
docs Ignored Ignored Jul 16, 2026 10:50am

Request Review

@coderabbitai

coderabbitai Bot commented Jul 16, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: f23afe9d-5ddf-4d2e-ad74-95b611a6b4d3

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Jul 16, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.65%. Comparing base (f7a302b) to head (af485e8).

Additional details and impacted files
@@                            Coverage Diff                            @@
##           feat/clickhouse-byo-warehouse-backend    #8028      +/-   ##
=========================================================================
- Coverage                                  98.65%   98.65%   -0.01%     
=========================================================================
  Files                                       1507     1508       +1     
  Lines                                      59866    59796      -70     
=========================================================================
- Hits                                       59060    58990      -70     
  Misses                                       806      806              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api Issue related to the REST API feature New feature or request front-end Issue related to the React Front End Dashboard

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant