feat: ClickHouse warehouse setup UI behind clickhouse_warehouse flag#8028
feat: ClickHouse warehouse setup UI behind clickhouse_warehouse flag#8028Zaimwa9 wants to merge 6 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## feat/clickhouse-byo-warehouse-backend #8028 +/- ##
=========================================================================
- Coverage 98.65% 98.65% -0.01%
=========================================================================
Files 1507 1508 +1
Lines 59866 59796 -70
=========================================================================
- Hits 59060 58990 -70
Misses 806 806 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Thanks for submitting a PR! Please check the boxes below:
docs/if required so people know about the feature.Changes
Frontend for the
clickhousewarehouse connection type, gated behind theclickhouse_warehouseflag (off by default). Builds on the backend in #8020.status_detailfield: the status tooltip shows the failure reason when the connection is errored, and the test-connection toast reports it instead of a generic message.credentials, read-onlystatus_detail.How did you test this code?
Unit tests for the form validation and payload helpers (
npm run test:unit -- --testPathPatterns=clickhouseConfig),npm run lint,npm run typecheck(no new errors against the baseline).Manually: enable the
clickhouse_warehouseflag, go to Environment Settings → Warehouse, connect a ClickHouse instance, then edit it and use Test connection to see verification results, including failure reasons.