fix: skip all API calls when generateGuestId is false and no userId is provided - #508
Merged
Merged
Conversation
…s provided Co-authored-by: Cursor <cursoragent@cursor.com>
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When
generateGuestIdis set tofalseand nouserIdis provided, the SDK previously still sent aPOST /v1/public/flowStatesrequest with an auto-generated guest ID on initialization, page navigation, and tab focus. This contradicted the prop's documented behavior ("Frigade will not initialize or render any Flows until a userId is provided") and generated API traffic for anonymous visitors.Fetchable.fetch()that skips all API requests whengenerateGuestId === falseand the effective userId is missing or aguest_ID. Since every request (flowStates, sessions, flow responses, tracking) goes through this method, this covers the full surface.flowStatesrefresh closure also returns early in this mode so the skipped request isn't misreported byhasFailedToLoad().isReady()remains true and callingidentify()with a real userId resumes normal behavior.Test plan
can disable guest id generationpasses (no flows anonymously →identify()→ flows load)fetchthat zero requests occur withgenerateGuestId: falseand no userId, and that requests resume afteridentify()Made with Cursor