Skip to content

refactor(tts): Remove tts_synthesize_text_audio_profile duplicated region tag#10311

Merged
Kef131 merged 2 commits into
mainfrom
refactor(tts)-remove_ttssynthesizetextaudioprofile_duplicated_tag
Jul 22, 2026
Merged

refactor(tts): Remove tts_synthesize_text_audio_profile duplicated region tag#10311
Kef131 merged 2 commits into
mainfrom
refactor(tts)-remove_ttssynthesizetextaudioprofile_duplicated_tag

Conversation

@Kef131

@Kef131 Kef131 commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

Description

Fixes #
b/536065373

Removes duplicated region tag tts_synthesize_text_audio_profile from texttospeech/snippets/src/main/java/com/example/texttospeech/SynthesizeText.java to prevent region tag collisions and ensure accurate snippet mapping in documentation.
NOTE: Don't remove file because it is used and linked to other region tags, which if neccessary will be treated in their own bug.

Checklist

Testing

  • I have tested this change on a live environment and verified it works as intended.
  • Tests pass: mvn clean verify required
  • Lint passes: mvn -P lint checkstyle:check required
  • Static Analysis: mvn -P lint clean compile pmd:cpd-check spotbugs:check advisory only

Compliance & Style

  • I have followed Sample Format Guide
  • pom.xml parent set to latest shared-configuration
  • Appropriate changes to README are included in PR
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample

Post-Approval Actions

  • Please merge this PR for me once it is approved

@product-auto-label product-auto-label Bot added samples Issues that are directly related to samples. api: texttospeech Issues related to the Text-to-Speech API. labels Jul 21, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the region tags for tts_synthesize_text_audio_profile in SynthesizeText.java. The review feedback points out that removing the start tag also removed a blank line, violating the Google Java Style Guide's vertical whitespace recommendation between class members, and suggests restoring it.

@Kef131 Kef131 self-assigned this Jul 21, 2026
@Kef131
Kef131 marked this pull request as ready for review July 22, 2026 22:58
@Kef131
Kef131 requested review from a team and yoshi-approver as code owners July 22, 2026 22:58
@snippet-bot

snippet-bot Bot commented Jul 22, 2026

Copy link
Copy Markdown

Here is the summary of changes.

You are about to delete 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@amcolin amcolin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As you mentioned this tag is duplicated, and the documentation is currently referencing the file.texttospeech/snippets/src/main/java/com/example/texttospeech/SynthesizeTextBeta.java so please go ahead.

@Kef131
Kef131 merged commit 019d7e9 into main Jul 22, 2026
15 checks passed
@Kef131
Kef131 deleted the refactor(tts)-remove_ttssynthesizetextaudioprofile_duplicated_tag branch July 22, 2026 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: texttospeech Issues related to the Text-to-Speech API. samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants