Smooth mode switching - #679
Open
RankoR wants to merge 8 commits into
Open
Conversation
RankoR
marked this pull request as ready for review
August 3, 2026 15:19
thestinger
force-pushed
the
main
branch
5 times, most recently
from
August 4, 2026 00:35
25fd41a to
db39c2d
Compare
m4pl
reviewed
Aug 4, 2026
Comment on lines
+77
to
+80
| val centers = (0 until tabParent.childCount).map { | ||
| val tabView = tabParent.getChildAt(it) | ||
| tabView.left + tabView.width / 2 - width / 2 | ||
| } |
There was a problem hiding this comment.
Could this use the children extension?
Suggested change
| val centers = (0 until tabParent.childCount).map { | |
| val tabView = tabParent.getChildAt(it) | |
| tabView.left + tabView.width / 2 - width / 2 | |
| } | |
| val centers = tabParent.children.take(tabCount).map { | |
| it.left + it.width / 2 - width / 2 | |
| }.toList() |
Separately, would it be worth iterating tabCount instead of childCount? Everything downstream compares the result against tabCount.
Comment on lines
115
to
122
| val target = tabCenters.getOrNull(tab.position) | ||
| val duration = if (target == null) 0L else settleDuration(abs(target - scrollX)) | ||
|
|
||
| // snapPoints is empty until the first layout pass, and goes stale when the tab set is | ||
| // rebuilt, so an index taken from it may no longer name a tab. | ||
| if (snapPoints.isEmpty() || snapPoints.last() == 0) { | ||
| if (target == null || duration == 0L || !ValueAnimator.areAnimatorsEnabled()) { | ||
| target?.let { scrollTo(it, 0) } | ||
| onSettled?.run() | ||
| return | ||
| } |
There was a problem hiding this comment.
Small thing: target == null gets tested twice.
Suggested change
| val target = tabCenters.getOrNull(tab.position) | |
| val duration = if (target == null) 0L else settleDuration(abs(target - scrollX)) | |
| // snapPoints is empty until the first layout pass, and goes stale when the tab set is | |
| // rebuilt, so an index taken from it may no longer name a tab. | |
| if (snapPoints.isEmpty() || snapPoints.last() == 0) { | |
| if (target == null || duration == 0L || !ValueAnimator.areAnimatorsEnabled()) { | |
| target?.let { scrollTo(it, 0) } | |
| onSettled?.run() | |
| return | |
| } | |
| val target = tabCenters.getOrNull(tab.position) ?: run { | |
| onSettled?.run() | |
| return | |
| } | |
| val duration = settleDuration(abs(target - scrollX)) | |
| if (duration == 0L || !ValueAnimator.areAnimatorsEnabled()) { | |
| scrollTo(target, 0) | |
| onSettled?.run() | |
| return | |
| } |
| val selectedWidth = selectedChild.width | ||
|
|
||
| return selectedChild.left + selectedWidth - width / 2 | ||
| private fun fractionalTabPosition(x: Int): Float { |
There was a problem hiding this comment.
nit: tabCenters.lastIndex in both spots reads a little better, and the empty case then falls out on its own.
| // is already visible and to dismiss it if the permission gets granted. | ||
| private var cameraPermissionDialog: AlertDialog? = null | ||
| private var audioPermissionDialog: AlertDialog? = null | ||
| @Volatile |
| if (frameCopyPending || hasFreshPrefetch()) return | ||
| if (previewView.width == 0 || previewView.height == 0) return | ||
|
|
||
| val surfaceView = previewView.getChildAt(0) as? SurfaceView ?: return |
sdsantos
reviewed
Aug 5, 2026
sdsantos
left a comment
sdsantos
left a comment
There was a problem hiding this comment.
Found a bug when changing tabs. If you click on a tab to change, and they quickly tap back on the tab you were before, the camera surface is stuck on the blurred preview and never shows the live camera, until you click on another tab.
camera_switch_stuck.mp4
|
|
||
| override fun onScrollChanged(x: Int, y: Int, oldX: Int, oldY: Int) { | ||
| super.onScrollChanged(x, y, oldX, oldY) | ||
| fun goToTab(tab: Tab, onSettled: Runnable? = null) { |
There was a problem hiding this comment.
Looks like nothing is using that onSettled.
m4pl
approved these changes
Aug 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.