fix: guard enclosure against None/non-positive length values - #457
Open
Zerthick wants to merge 1 commit into
Open
fix: guard enclosure against None/non-positive length values#457Zerthick wants to merge 1 commit into
Zerthick wants to merge 1 commit into
Conversation
When a remote image returns 404, the length field becomes None, producing invalid XML. Added guard to skip enclosure when length is None or non-positive. - Add guard condition in rss.xml.jinja2 template - Add test verifying no invalid enclosure length values
github-actions
Bot
added
bug
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Guard
<enclosure>element againstNoneor non-positive length values in the RSS feed.When a remote image returns 404, the length field becomes
None, which would produce invalid XML like<enclosure length="None" />. This PR adds a guard to skip the enclosure element when length isNoneor non-positive.Changes
rss.xml.jinja2template: check thatitem.image[2]is notNoneand is greater than 0Split from: #451