chore: change the server image name - #30
Merged
Merged
Conversation
Signed-off-by: kerthcet <kerthcet@gmail.com>
InftyAI-Agent
added
needs-triage
Contributor
There was a problem hiding this comment.
Pull request overview
This PR standardizes the naming/reference for the tunnel-enabled server Dockerfiles by switching documentation and examples from the older Dockerfile.tunnel* naming to Dockerfile.server-tunnel*.
Changes:
- Updated Docker build instructions in
hack/docker/README.md,docs/proposals/TUNNEL.md, andexamples/tunnel-simple/README.mdto useDockerfile.server-tunnel/Dockerfile.server-tunnel-release. - Updated
examples/tunnel-simple/docker-compose.ymlto build the controller image usinghack/docker/Dockerfile.server-tunnel. - Updated header build comment in
hack/docker/Dockerfile.server-tunnel-releaseto reflect the new filename.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| hack/docker/README.md | Updates documented server tunnel Dockerfile names/paths and build commands. |
| hack/docker/Dockerfile.server-tunnel-release | Updates header build comment to the new filename/path. |
| hack/docker/Dockerfile.server-tunnel | Updates header build comment to the new filename (but currently documents an invalid build invocation). |
| examples/tunnel-simple/README.md | Updates manual build instructions to the new server tunnel Dockerfile name/path. |
| examples/tunnel-simple/docker-compose.yml | Points the controller build to Dockerfile.server-tunnel. |
| docs/proposals/TUNNEL.md | Updates tunnel docs references/build commands to Dockerfile.server-tunnel. |
Suppressed comments (1)
hack/docker/Dockerfile.server-tunnel:9
- The build command in the Dockerfile header suggests building with
-f Dockerfile.server-tunnel(implying you run fromhack/dockerwith context.). That context would exclude the repo root, but this Dockerfile doesCOPY . .expecting the full repository (e.g.,pyproject.toml) to be present, so the documented command will fail when copy/pasted.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
Author
|
/lgtm |
InftyAI-Agent
added
lgtm
InftyAI-Agent
approved these changes
Aug 3, 2026
InftyAI-Agent
left a comment
InftyAI-Agent
left a comment
Member
There was a problem hiding this comment.
Approved: PR has both lgtm and approved labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
Which issue(s) this PR fixes
Fixes #
Special notes for your reviewer
Does this PR introduce a user-facing change?