fix the image name - #31
Merged
Merged
Conversation
Signed-off-by: kerthcet <kerthcet@gmail.com>
InftyAI-Agent
added
needs-triage
Contributor
There was a problem hiding this comment.
Pull request overview
Updates documentation and Dockerfile headers to use the corrected Docker image names/tags for tunnel-enabled SandD images (controller/server and daemon/worker), keeping build/run examples consistent across the repo.
Changes:
- Renames tunnel image tags in
hack/docker/README.md,docs/proposals/TUNNEL.md, andexamples/tunnel-simple/README.md. - Updates build/run header comments in tunnel-related Dockerfiles to reflect the new image names.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| hack/docker/README.md | Updates documented docker build commands to the new tunnel image tags. |
| hack/docker/Dockerfile.server-tunnel-release | Updates header build/run examples to the new server-tunnel image tag. |
| hack/docker/Dockerfile.server-tunnel | Updates header build/run examples to the new server-tunnel image tag. |
| hack/docker/Dockerfile.daemon-tunnel-release | Updates header build/run examples to the new daemon-tunnel image tag. |
| examples/tunnel-simple/README.md | Updates example build instructions and FROM image reference to the new server-tunnel image tag. |
| docs/proposals/TUNNEL.md | Updates proposal docs to the new server-tunnel build/run image references. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| # | ||
| # Build: docker build -f Dockerfile.server-tunnel -t inftyai/sandd-server:latest-tunnel . | ||
| # Run: docker run --cap-add NET_ADMIN --device /dev/net/tun inftyai/sandd-server:latest-tunnel | ||
| # Build: docker build -f Dockerfile.server-tunnel -t inftyai/sandd-server-tunnel:latest . |
Signed-off-by: kerthcet <kerthcet@gmail.com>
Member
Author
|
/lgtm |
InftyAI-Agent
added
lgtm
kerthcet
force-pushed
the
cleanup/change-image-name
branch
from
August 3, 2026 09:22
8625ccd to
eabc951
Compare
InftyAI-Agent
removed
the
lgtm
Signed-off-by: kerthcet <kerthcet@gmail.com>
Member
Author
|
/lgtm |
InftyAI-Agent
added
the
lgtm
InftyAI-Agent
approved these changes
Aug 3, 2026
InftyAI-Agent
left a comment
InftyAI-Agent
left a comment
Member
There was a problem hiding this comment.
Approved: PR has both lgtm and approved labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
Which issue(s) this PR fixes
Fixes #
Special notes for your reviewer
Does this PR introduce a user-facing change?