Pin Vale to 3.14.2 to fix dicpath resolution regression#916
Closed
rrrutledge wants to merge 1 commit into
Closed
Conversation
Vale 3.15.0 (released 2026-06-12) changed vale sync to create and use the configured StylesPath instead of falling back to a global styles directory (vale-cli/vale#1105/#1106). That changed where the ISC style package's nested styles/ISC/Spelling.yml and styles/dictionaries land under .github/vale, breaking Spelling.yml's relative `dicpath: dictionaries` and failing every Spelling & Styles run since with "unable to resolve dicpath" - unrelated to any PR's content. 3.14.2 was the last version where sync resolved dicpath correctly.
Contributor
Author
|
Closing in favor of the real fix at the source: InnerSourceCommons/isc-styles#4. That removes the stray StylesPath line causing the dicpath failure, so every consumer (this repo, InnerSourceLearningPath, managing-innersource-projects) is fixed once it merges — no per-repo pin needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
Spelling & Stylesworkflow has failed on every PR (and the monthlymainschedule run) since 2026-06-15, withvaleerroringunable to resolve dicpathon.github/vale/ISC/Spelling.yml— unrelated to any PR's content.Root cause
vale-action@v2defaults toversion: latest. Vale 3.15.0 (released 2026-06-12) changedvale syncto create and use the configuredStylesPath(.github/vale) instead of falling back to a global styles directory (vale-cli/vale#1106). That changed where theISCpackage's nestedstyles/ISC/Spelling.ymlandstyles/dictionaries/land once synced, breakingSpelling.yml's relativedicpath: dictionaries.3.14.2was the last Vale release before that sync change — pinning to it restores the working layout. The isc-styles package itself hasn't changed since 2025-08-28, so this is a Vale-version compatibility issue, not a content or package issue.Fix
Pin
vale-action'sversioninput to3.14.2instead of floating onlatest.Longer-term
isc-styles'Spelling.yml/dicpathshould eventually be restructured to work under the new (correct) sync behavior so we can move off the pin — filing that separately againstisc-styles.Test plan
Spelling & Stylescheck should now pass (self-verifying, sincepull_requestruns the workflow from this branch).