fix(appinsights): set browser app id for correlation - #1266
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the web app’s Application Insights browser instrumentation to support improved client/server correlation by exposing the AI App ID to the browser and configuring the JS SDK to use it, while keeping correlation headers restricted to the site and Try origins.
Changes:
- Expose
APPLICATIONINSIGHTS_APP_IDto the browser via_Layout.cshtml. - Configure the Application Insights browser SDK with
appIdand clarify the intent of the correlation header domain allow-list.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| EssentialCSharp.Web/wwwroot/js/appinsights-manager.js | Reads the exposed App ID and passes it into the browser SDK config to support correlation; documents the restricted correlation header domain behavior. |
| EssentialCSharp.Web/Views/Shared/_Layout.cshtml | Adds a serialized window.APPLICATIONINSIGHTS_APP_ID value so the browser telemetry manager can configure correlation. |
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary\n- expose the Application Insights app id to the browser\n- configure the browser SDK with the app id for client/server correlation\n- keep correlation headers limited to the web and Try origins\n\n## Testing\n- dotnet build EssentialCSharp.Web.slnx -c Release /p:AccessToNugetFeed=false