NDI-matlab functionality: reading from ndi.element.timeseries objects, writing ndi.neuron objects - #157
Open
stevevanhooser wants to merge 25 commits into
Open
NDI-matlab functionality: reading from ndi.element.timeseries objects, writing ndi.neuron objects#157stevevanhooser wants to merge 25 commits into
stevevanhooser wants to merge 25 commits into
Conversation
prevents overwriting of prm parameter values by default values fixes renumbering of spike sites when KiloSort returns partial channel map
Collaborator
|
You're right about the export documentation, there's not much (or none) to speak of. I can work on standing that up. Can I ask that you add a few unit tests? I'm happy to talk offline about the test framework I've set up. |
Author
|
Hi Alan - Yes, I'd be delighted to add unit tests. Can you point me to an example, maybe an Intan example, or any other example that you think would be useful? -Steve |
Collaborator
|
Unit tests are another thing I'm still building out -- in particular there aren't any reading or import/export tests (you probably saw this already). I think at a bare minimum, if you can write something out with NDI and read it back in with JRCLUST, and everything is where you expect it to be, that would be useful. We can talk about edge cases when we meet. |
bootstrapNDI built the per-element analysis folder under '.JRCLUST' from
ndi.element/elementstring, which separates an element's name from its
reference with ' | '. That produced directories like '.JRCLUST/ctx_|_1',
and '|' is not a legal filename character on Windows, so the bootstrap
could not run there at all.
Build the folder name with ndi.fun.file.elementDirectory instead. It
returns the platform-independent name ('ctx_-_1') and falls back to an
existing legacy '|' folder when one is present, so an analysis directory
created by an earlier version is reused rather than orphaned. Error
clearly if the installed NDI predates that helper.
ndiTest hard-coded the old separator in a '*_|_*' directory glob; it now
resolves the folder the same way the bootstrap does and asserts that the
name contains no '|'.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01CzVqXZ4qsFEHZPPszVVqVH
…ey-skmqsn Use NDI helper for platform-independent element directory naming
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These modifications allow:
Requires http://github.com/VH-Lab/NDI-matlab for these functions (error is given if not installed)
Still needed:
There appears to be no documentation for the export methods (or, I didn't find it). I would like to add documentation to the export ndi function in the documentation.