[Refactor] evaluation runtime 경계 분리 (#270) - #275
Conversation
|
Warning Review limit reached
Next review available in: 10 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (17)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
✨ 어떤 이유로 PR를 하셨나요?
📋 세부 내용 - 왜 해당 PR이 필요한지 작업 내용을 자세하게 설명해주세요
evaluation 코드가 runtime analysis 구현을 직접 아는 범위를 단계적으로 줄이기 위해 경계를 한 번 더 정리했습니다.
EvaluationSanitizationService뒤로 감싸서 evaluation 서비스들이 runtime sanitization 클래스를 직접 import하지 않도록 바꿨습니다.EvaluationAnalysisBatchService앞에EvaluationAnalysisGeneratorport를 두고, 기존AnalysisAiClient호출은 adapter로 이동했습니다.command/result모델만 다루고, 관련 테스트도 같은 경계를 기준으로 갱신했습니다.이 변경으로 evaluation 리팩터링을 작은 커밋 단위로 이어갈 수 있는 기반을 만들었고, 이후 runtime analysis 쪽 변경이 evaluation 배치 서비스로 바로 전파되는 결합도 한 단계 낮췄습니다.
📸 작업 화면 스크린샷
🚨 관련 이슈 번호 [ #270 ]