Refactor/#270 evaluation runtime decouple - #276
Conversation
|
Warning Review limit reached
Next review available in: 25 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (4)
📝 WalkthroughWalkthrough평가 분석 생성을 Changes평가 분석 리팩터링
Estimated code review effort: 4 (Complex) | ~45 minutes Possibly related issues
Possibly related PRs
Sequence Diagram(s)sequenceDiagram
participant EvaluationAnalysisBatchService
participant AnalysisAiEvaluationAnalysisGenerator
participant JobCategoryCriteriaProvider
participant AnalysisAiClient
EvaluationAnalysisBatchService->>AnalysisAiEvaluationAnalysisGenerator: 분석 명령 전달
AnalysisAiEvaluationAnalysisGenerator->>JobCategoryCriteriaProvider: 중분류 기준 조회
AnalysisAiEvaluationAnalysisGenerator->>AnalysisAiClient: 평가 분석 요청
AnalysisAiClient-->>AnalysisAiEvaluationAnalysisGenerator: 응답 및 후보 검토 결과 반환
AnalysisAiEvaluationAnalysisGenerator-->>EvaluationAnalysisBatchService: 생성 결과 반환
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@src/main/java/com/jobdri/jobdri_api/domain/evaluation/analysis/adapter/AnalysisAiEvaluationAnalysisGenerator.java`:
- Around line 39-44: AnalysisAiEvaluationAnalysisGenerator의 사례 처리 흐름에 사례 단위
deadline을 추가하세요. TWO_PASS와 HYBRID_EXACT의 다중 AI 호출 및 OpenAiConfig의 재시도를 포함해 전체 사례
대기 시간이 모드별 예산을 넘지 않도록 각 호출에 남은 시간을 전달·적용하고, deadline 초과 시 해당 사례를 중단하되 후속 사례 처리와
CSV 출력은 계속되게 하세요.
In
`@src/test/java/com/jobdri/jobdri_api/domain/evaluation/analysis/EvaluationAnalysisBatchServiceTest.java`:
- Around line 99-100: EvaluationAnalysisBatchServiceTest의 generator.generate 검증이
호출 횟수와 인자 존재 여부만 확인하므로, EvaluationAnalysisCommand 인자를 capture하도록 변경하고 CSV 입력의
caseId, 중분류, 소분류, 질문, 답변 및 순서를 모두 검증하세요.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 34b9c36d-2850-49da-a02c-04ad456d4ffb
📒 Files selected for processing (9)
src/main/java/com/jobdri/jobdri_api/domain/evaluation/analysis/EvaluationAnalysisBatchService.javasrc/main/java/com/jobdri/jobdri_api/domain/evaluation/analysis/MissingKeywordSanitizerReplayService.javasrc/main/java/com/jobdri/jobdri_api/domain/evaluation/analysis/NlgEvaluationBatchService.javasrc/main/java/com/jobdri/jobdri_api/domain/evaluation/analysis/adapter/AnalysisAiEvaluationAnalysisGenerator.javasrc/main/java/com/jobdri/jobdri_api/domain/evaluation/analysis/model/EvaluationAnalysisCommand.javasrc/main/java/com/jobdri/jobdri_api/domain/evaluation/analysis/model/EvaluationGeneratedResult.javasrc/main/java/com/jobdri/jobdri_api/domain/evaluation/analysis/port/EvaluationAnalysisGenerator.javasrc/main/java/com/jobdri/jobdri_api/domain/evaluation/analysis/sanitization/EvaluationSanitizationService.javasrc/test/java/com/jobdri/jobdri_api/domain/evaluation/analysis/EvaluationAnalysisBatchServiceTest.java
1 participant
✨ 어떤 이유로 PR를 하셨나요?
📋 세부 내용 - 왜 해당 PR이 필요한지 작업 내용을 자세하게 설명해주세요
📸 작업 화면 스크린샷
🚨 관련 이슈 번호 [ ]
Summary by CodeRabbit
새 기능
개선