fix(watch): preserve final writes in debounce bursts#81
Open
reneleonhardt wants to merge 1 commit into
Open
Conversation
Co-Authored-By: GPT-5.6 Sol <codex@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
os.Stat, avoiding that syscall for missing/untracked paths.Type of change
Checklist
Additional notes
This follows the three review observations on #78: preserve same-size edits with modification time, add a trailing edge for changed bursts, and consult cached state before filesystem inspection. The event loop remains the sole owner of the timer and pending map.
The test matrix now covers Go 1.24 through 1.26. The previous 1.21–1.23 labels no longer exercised those toolchains because the Go 1.24 module minimum caused automatic toolchain replacement.
Verification includes 20 consecutive focused race runs, the full macOS Go 1.26.5 race/coverage suite,
go vet ./..., the full Linux Go 1.24 race/coverage suite, and 95.76% changed executable production-line coverage. Final adversarial review found no remaining Critical or Important issues.Developed with carefully directed, manually reviewed AI assistance.
Co-Authored-By: GPT-5.6 Sol codex@openai.com