Harden statement caching and resource handling - #56
Merged
Conversation
Co-authored-by: Max Horn <max@quendi.de>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #56 +/- ##
===========================================
+ Coverage 4.08% 82.25% +78.17%
===========================================
Files 1 1
Lines 49 124 +75
===========================================
+ Hits 2 102 +100
+ Misses 47 22 -25 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
LazyNamedIndex subtypes AbstractDict but did not define Base.get, so haskey, get, and key-membership checks raised MethodError. SQLite.jl and DuckDB.jl bind named parameters through haskey, so executemany failed for every AbstractDict batch. Define haskey and both get forms and test them, verified against live SQLite and DuckDB inserts. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This was referenced Aug 10, 2026
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR records a full correctness, performance, security, API, documentation, and open-issue review of DBInterface.jl.
@prepare.NamedTuplebehavior inexecutemany.connectandprepareforms.Commit list
eb116a3fixes macro hygiene, dynamic SQL, connection identity, and cache locking.c5b275bpreserves namedAbstractDictbatches and closes bounded resources.b90218epreserves transaction and rollback failure context.3624e54adds scoped connection and statement forms.d6b328bdisplays interface error messages normally.0620977clarifies parameters, SQL safety, and resource ownership.e99fee3repairs the docs build on current Documenter.a4b6568updates workflows and includes the work proposed in Update TagBot config #53 and Update GitHub actions #54, with Max Horn credited in the commit.786bfedskips transactions for empty bulk batches.f575491retains downstream-compatible positionalNamedTuplebatches.955962eraises the supported Julia floor to 1.9.e43c845retains prepared statements across a bounded connection pool and closes changed SQL entries.292df0dcompletes theAbstractDictcontract for dictionary batch rows, whichhaskey-based drivers such as SQLite.jl and DuckDB.jl require.3be366dbumps the package version to 2.7.0 for release.Open issue review
DBInterface.@preparefails when used with multiple connections #52.Validation
DBInterface.@preparefails when used with multiple connections #52 passes.Co-authored by Codex