[NET-1388] refactor: Resolve limit config at init-time instead of import-time#341
Open
akash-vijay-kv wants to merge 2 commits into
Open
[NET-1388] refactor: Resolve limit config at init-time instead of import-time#341akash-vijay-kv wants to merge 2 commits into
akash-vijay-kv wants to merge 2 commits into
Conversation
akash-vijay-kv
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
ATTRIBUTE_MAX_LEN/CONVERSATION_MAX_LEN/TRIAL_BLOCK_DURATION_SECONDSfrom import-time class attributes to instance attributes resolved duringConfig.__init__, with module-level defaults as pre-init fallback.set_active_config()/get_active_config()and typed getters: updates consumers to read via getters instead of class attributes, with no constructor/signature changes.JIRA
https://getnetra.atlassian.net/browse/NET-1388