Skip to content

Refactor MailHelper to be more provider-agnostic#7848

Merged
labkey-adam merged 3 commits into
developfrom
fb_mailhelper_refactor
Jul 21, 2026
Merged

Refactor MailHelper to be more provider-agnostic#7848
labkey-adam merged 3 commits into
developfrom
fb_mailhelper_refactor

Conversation

@labkey-adam

@labkey-adam labkey-adam commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

Rationale

The first Related PR added support for our first non-SMTP email provider (Microsoft Graph API email transport), but MailHelper and related classes remained very tied to SMTP. This takes steps toward making MailHelper provider-agnostic. https://github.com/LabKey/kanban/issues/1714

Related Pull Requests

Changes

  • Register SMTP provider like other providers
  • Improve configuration error to not hard-code any provider information - list only the providers that are available
  • Fix some potential concurrency issues

@labkey-bpatel labkey-bpatel left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
Found no issues during manual test.

@labkey-adam
labkey-adam merged commit b5ffe7f into develop Jul 21, 2026
8 checks passed
@labkey-adam
labkey-adam deleted the fb_mailhelper_refactor branch July 21, 2026 20:33
labkey-adam added a commit to LabKey/testAutomation that referenced this pull request Jul 21, 2026
## Rationale
Dumbster changes to support a somewhat more agnostic MailHelper

## Related Pull Requests
- LabKey/platform#7848
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants