Skip to content

Fix for testStudyProtocolDesigner() #7871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DariaBod wants to merge 4 commits into
base: develop
Choose a base branch
from
+9 −12
Open

Fix for testStudyProtocolDesigner() #7871

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8c08b13
fix
DariaBod Jul 21, 2026
9f4344a
fix style
DariaBod Jul 21, 2026
8994d3f
Merge branch 'develop' into fb_fixForStudyProtocolDesignerTest
DariaBod Jul 22, 2026
385794c
exclude backslash
DariaBod Jul 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 9 additions & 12 deletions study/test/src/org/labkey/test/tests/study/StudyProtocolDesignerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,21 +86,18 @@ public class StudyProtocolDesignerTest extends BaseWebDriverTest implements Post
private static final String[] NEW_COHORTS = {"TestCohort", "OtherTestCohort"};
private static final String[] CHALLENGES = {"Challenge1", "Challenge2", "Challenge3"};

private static String trickyVisitLabel(String part)
{
return TestDataGenerator.randomName(part, 3, 3, TRICKY_CHARACTERS, null).name();
}

private static final List<BaseManageVaccineDesignVisitPage.Visit> VISITS = Arrays.asList(
new BaseManageVaccineDesignVisitPage.Visit(trickyVisitLabel("Enrollment"), 0.0, 0.0),
new BaseManageVaccineDesignVisitPage.Visit(trickyVisitLabel("Visit 1"), 1.0, 1.0),
new BaseManageVaccineDesignVisitPage.Visit(trickyVisitLabel("Visit 2"), 2.0, 2.0),
new BaseManageVaccineDesignVisitPage.Visit(trickyVisitLabel("Visit 3"), 3.0, 3.0),
new BaseManageVaccineDesignVisitPage.Visit(trickyVisitLabel("Visit 4"), 4.0, 4.0)
new BaseManageVaccineDesignVisitPage.Visit("Enrollment", 0.0, 0.0),
new BaseManageVaccineDesignVisitPage.Visit("Visit 1", 1.0, 1.0),
new BaseManageVaccineDesignVisitPage.Visit("Visit 2", 2.0, 2.0),
new BaseManageVaccineDesignVisitPage.Visit("Visit 3", 3.0, 3.0),
new BaseManageVaccineDesignVisitPage.Visit("Visit 4", 4.0, 4.0)
);

private static final List<BaseManageVaccineDesignVisitPage.Visit> NEW_VISITS = Arrays.asList(
new BaseManageVaccineDesignVisitPage.Visit(trickyVisitLabel("NewVisit1"), 6.0, 7.0),
new BaseManageVaccineDesignVisitPage.Visit(trickyVisitLabel("NewVisit2"), 8.0, 8.0)
new BaseManageVaccineDesignVisitPage.Visit(TestDataGenerator.randomName("NewVisit1", 3, 3, TRICKY_CHARACTERS, "\\").name(), 6.0, 7.0),
new BaseManageVaccineDesignVisitPage.Visit(TestDataGenerator.randomName("NewVisit2", 3, 3, TRICKY_CHARACTERS, "\\").name(), 8.0, 8.0)
Comment on lines +99 to +100

@labkey-tchad labkey-tchad Jul 22, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any characters excluded from fuzzing should include an explanation in the code.
That being said, I ran this locally with a backslash intentionally added and it seems like there's a product defect. When we hit something like this in the tests, we should open an issue; that's the whole point of adding this fuzzing coverage.
Also, we should fuzz with TestDataGenerator.CHARSET_STRING. It contains a wider variety of characters that might cause problems.

);


Expand Down Expand Up @@ -294,7 +291,7 @@ public void testManageTreatmentsSingleTable()
{
ManageTreatmentsSingleTablePage singleManagementTable;
TreatmentDialog treatmentDialog;
List<String> EXPECTED_HEADERS = new ArrayList<>(Arrays.asList("Group / Cohort", "Participant Count", "Enrollment", "Visit 1", "Visit 2", "NewVisit1", "NewVisit2"));
List<String> EXPECTED_HEADERS = new ArrayList<>(Arrays.asList("Group / Cohort", "Participant Count", "Enrollment", "Visit 1", "Visit 2", NEW_VISITS.get(0).getLabel(), NEW_VISITS.get(1).getLabel()));
String tempText;

// These are the expected Immunogen options:
Expand Down