fix the 401 error on faces when a visitor loads a photo

[jphuguet]

fix the 401 error on faces when a visitor loads a photo

Summary by CodeRabbit

• Bug Fixes
  • Improved face visibility controls in photo details.
  • Face data is no longer requested when face recognition or face overlays are unavailable.
  • Prevented face information from being displayed without the required permissions and features.

[coderabbitai]

📝 Walkthrough

Walkthrough

Both v7 and v8 PhotoDetails components now require face recognition and face overlay modules for face rendering and fetching. Their watchers skip face requests when visibility, photo ID, or detected faces are unavailable.

Changes

Face visibility gating

Layer / File(s)	Summary
Shared face visibility guard resources/js/v7/components/drawers/PhotoDetails.vue, resources/js/v8/components/drawers/PhotoDetails.vue	Both components define areFacesVisible from the face-recognition and face-overlay module states. The people-in-photo sections use this guard.
Conditional face fetching resources/js/v7/components/drawers/PhotoDetails.vue, resources/js/v8/components/drawers/PhotoDetails.vue	Both face-fetch watchers observe visibility changes and skip requests when overlays are unavailable, the photo ID is missing, or no faces are detected.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: 🟡 Moderate · up to f6ff4

The change still disables face rendering and face-data loading for authorized users because both versions use the wrong overlay state field. Replace it with the shared visibility field before merging.

Poem

I’m a rabbit guarding faces bright,
Two modules must approve the light.
If overlays hide or photos fade,
No needless fetch requests are made.
Hop, hop—the guard is shared today!

🚥 Pre-merge checks | ✅ 1

✅ Passed checks (1 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

Actionable comments posted: 1

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 77143752-aace-4c6e-8b1c-af522b63857c

📥 Commits

Reviewing files that changed from the base of the PR and between 9aafefc and f6ff433.

📒 Files selected for processing (2)

• resources/js/v7/components/drawers/PhotoDetails.vue
• resources/js/v8/components/drawers/PhotoDetails.vue

Included review availability: Your plan provides up to 8 included reviews per hour; 6 remain after this review.

[ildyria]

is_face_recognition_enabled < The fix should be to set this to false when the person has no access to the facial recognition capabilities.