Skip to content

Non-Engine Cleanup From Zix - #1220

Draft
prothegee wants to merge 2 commits into
MDA2AV:mainfrom
prothegee:zix-non_engine_cleanup
Draft

Non-Engine Cleanup From Zix#1220
prothegee wants to merge 2 commits into
MDA2AV:mainfrom
prothegee:zix-non_engine_cleanup

Conversation

@prothegee

Copy link
Copy Markdown
Contributor

Resolving: #1215

Removing 22 files where the files are not engine category from zix.

@MDA2AV

MDA2AV commented Aug 21, 2026

Copy link
Copy Markdown
Owner

just change the type in meta.json to engine on them and run benchmarks with --save. the script will take care of things, dont manually delete these files

@prothegee

Copy link
Copy Markdown
Contributor Author

It appear the entry use correct keyword for the type in meta.json
image

And the result of site/data/frameworks.json already correct with their variants.
image

I'm not sure where the zix emerging type came from.

Previously when each entry use --save it's not collide. But after pr #998 merged. Some zix existing entries (websocket, grpc, & http3) are gone.

The remaining check is on the 3 files. But I believed it was generated when submitted. Correct me if I'm wrong.

➜ rg -l "zix\-.*" | xargs rg -l "emerging"
site/data/frameworks.json
scripts/gen_leaderboard_data.py
site/leaderboard/data.js

Should I made a re-bench and we check result first at least one of the other entry?
Then let this open for a while and see what happen? @MDA2AV

Regards,
Prana Ron

@MDA2AV

MDA2AV commented Aug 21, 2026

Copy link
Copy Markdown
Owner

Yes, open or reuse the existing PRs and lets do a benchmark --save to see if it fixes, maybe some issue happened during scripts updates

@prothegee

Copy link
Copy Markdown
Contributor Author

Ok. Converting this pull-request as draft till further update.

@prothegee
prothegee marked this pull request as draft August 21, 2026 07:54
@MDA2AV

MDA2AV commented Aug 21, 2026

Copy link
Copy Markdown
Owner

if anything, just merge all your open PRs and then Ill land a fix that directly updates all results to engine if the issue persists

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants