express: json-tls, static-tls, crud and fortunes - #1247
Open
MDA2AV wants to merge 2 commits into
Open
Conversation
The four HTTP/1.1 profiles the entry was not subscribed to.
json-tls and static-tls are the same app behind a node:https server on 8081.
Every worker binds it exactly as they all bind 8080, so the cluster shares the
port rather than one process carrying it.
crud runs cache-aside on Redis through ioredis, one connection per worker so the
cache is shared across the cluster, with a 200ms TTL and an explicit delete on
update. express.json() is mounted on the two crud routes that carry a body
rather than globally, so /upload keeps counting its 20MB body as it streams
instead of having it buffered and parsed.
fortunes renders through a view engine, which is what standard mode asks for -
the template is its own artifact at views/fortunes.hbs and Handlebars escapes
{{ }} by default. The seed's row 11 carries a <script> tag and the profile's
load-bearing check is that it leaves as text.
express.static already streamed bodies from disk, so static-tls needed no change
to the static path.
Validation: 64 passed, 0 failed.
Owner
Author
|
/benchmark --save |
Contributor
|
👋 Benchmark request received. A collaborator will review and approve the run. |
Contributor
Benchmark ResultsFramework:
Full log |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The four HTTP/1.1 profiles the entry was not subscribed to. Tests go from 10 to 14.
json-tls / static-tls
The same app behind a
node:httpsserver on 8081. Every worker binds it exactlyas they all bind 8080, so the cluster shares the port rather than one process
carrying it — the failure mode #1245 fixed on quarkus.
express.staticalready streamed bodies from disk, so the static path needed nochange to take
static-tls.crud
Cache-aside on Redis through
ioredis, one connection per worker so the cache isshared across the cluster rather than being a per-worker map, 200ms TTL, explicit
delete on update.
express.json()is mounted on the two crud routes that carry abody rather than globally —
/uploadtakes a 20MB body it counts as it streams,and a global parser would buffer and parse it.
fortunes
Rendered through a view engine, which is what standard mode requires: the
template is its own artifact at
views/fortunes.hbs, and Handlebars escapes{{ }}by default. The seed's row 11 carries a<script>tag and the profilecalls that escape its load-bearing check.
Validation
64 passed, 0 failed, including all four new profiles:
🤖 Generated with Claude Code