Skip to content

Fix missing qv term in the Lagrange bubble initial pressure #1709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sbryngelson merged 2 commits into from
Aug 9, 2026
+185 −1
Merged

Fix missing qv term in the Lagrange bubble initial pressure #1709

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
174775f
Fix missing qv term in the Lagrange bubble initial pressure
sbryngelson Aug 8, 2026
9191c9a
Add golden for the qv_nonzero Lagrange bubble regression case
sbryngelson Aug 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/simulation/m_bubbles_EL.fpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -371,7 +371,9 @@ contains
do i = 1, num_dims
dynP = dynP + 0.5_wp*q_cons_vf(eqn_idx%cont%end + i)%sf(cell(1), cell(2), cell(3))**2/rhol
end do
pliq = (q_cons_vf(eqn_idx%E)%sf(cell(1), cell(2), cell(3)) - dynP - pi_inf)/gamma
! Stiffened-gas inversion; must match s_compute_pressure in m_variables_conversion,
! including the qv (heat of formation) term, which is nonzero for phase-change fluids.
pliq = (q_cons_vf(eqn_idx%E)%sf(cell(1), cell(2), cell(3)) - dynP - pi_inf - qv)/gamma
if (pliq < 0) print *, "Negative pressure", proc_rank, q_cons_vf(eqn_idx%E)%sf(cell(1), cell(2), cell(3)), pi_inf, gamma, &
& pliq, cell, dynP

Expand Down
154 changes: 154 additions & 0 deletions tests/F428FDC0/golden-metadata.txt
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading