Enforce privileged LTI launch role for course linking and creation - #8130
Open
donny-wong wants to merge 4 commits into
Open
Enforce privileged LTI launch role for course linking and creation#8130donny-wong wants to merge 4 commits into
donny-wong wants to merge 4 commits into
Conversation
Collaborator
Coverage Report for CI Build 32064400081Coverage increased (+0.006%) to 90.638%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
(Describe your changes here. Also describe the motivation for your changes: what problem do they solve, or how do they improve the application or codebase? If this pull request fixes an open issue, use a keyword to link this pull request to the issue.)
Currently the Canvas role check only decides where to redirect after an LTI launch — it is not enforced on the pages themselves. This means any logged-in MarkUs user could go directly to the choose_course URL and create a course, even if they are a student on Canvas. This PR fixes that: a successful privileged launch is now recorded in the session, and choose_course/create_course return a 403 "Launch Required" page unless the user launched that deployment from the LMS with an instructor role. Also re-enables CSRF protection on create_course. Specs updated with tests for the forbidden cases.
Screenshots of your changes (if applicable)
Type of Change
(Write an
Xor a brief description next to the type or types that best describe your changes.)Checklist
(Complete each of the following items for your pull request. Indicate that you have completed an item by changing the
[ ]into a[x]in the raw text, or by clicking on the checkbox in the rendered description on GitHub.)Before opening your pull request:
After opening your pull request:
Questions and Comments
(Include any questions or comments you have regarding your changes.)