⚡ Implement concurrent notification teardown (Promise.all) - #54
Conversation
In `notifications.service.ts`, several flows loop over managed local states to cancel scheduled notifications. Previously these loops `await`ed `cancelScheduledNotification` sequentially. This commit changes these flows to construct arrays of promises and resolve them simultaneously using `Promise.all`. This significantly reduces the time it takes to teardown managed notifications, especially for users with numerous active schedules.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
💡 What:
Replaced sequential
forloops containingawait this.cancelScheduledNotification(...)with concurrentawait Promise.all(...)executions inclearManagedNotificationsandsyncManagedPlans.🎯 Why:
Previously, clearing notifications (e.g. syncing deadline and opportunity notifications) happened sequentially. This means that network or IPC latency was paid on every single cancellation in sequence, taking longer as the number of notifications grew. Running them concurrently avoids this overhead.
📊 Measured Improvement:
Based on synthetic testing with mocked IPC latency (10ms per cancellation) for 50 notifications:
PR created automatically by Jules for task 348080142222865754 started by @MarsLuay