🧹 fix empty catch block in scorecard.ts - #57
Conversation
Changes empty catch block in `getApiKeyErrorMessage` to capture non-SyntaxErrors via `errorLoggingService`. This addresses the empty catch block code health issue while preserving the intentional swallowing of non-JSON error bodies (`SyntaxError`).
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🎯 What: The code health issue regarding an empty catch block in
source/services/colleges/scorecard.tsat line 103 has been fixed.💡 Why: Empty catch blocks hide bugs. We conditionally catch non-SyntaxError exceptions to log unexpected errors while keeping the intentional swallow of normal non-JSON responses.
✅ Verification: Verified by running
npm run typecheck,npm run lint, and all tests (npm run test:fetch-contract,npm run test:app) which passed cleanly.✨ Result: Improved maintainability by properly logging unexpected errors instead of quietly ignoring everything.
PR created automatically by Jules for task 7539190264920004767 started by @MarsLuay