🧪 Add test file for Scorecard Service - #58
Conversation
- Introduced `scorecard.test.cjs` verifying `fetchScorecardUrl` and `buildScorecardUrl`. - Validated in-memory cache TTL hit and miss logic. - Tested appropriate error bubbling during retries, 500 transient errors, and invalid API keys (in both JSON and HTML/text payload errors). - Mocked specific expo dependencies that are incompatible in raw Node test environments.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🎯 What: The testing gap for College Scorecard API fetching/caching logic has been addressed. The
fetchScorecardUrlhelper handles complex timeouts, transient HTTP codes, and invalid keys. This required a dedicated file to mock responses and ensure robustness.📊 Coverage:
✨ Result: A full suite (13 specific tests) now provides a safety net ensuring modifications to fetching, retry timings, or URL construction will not regress app logic.
PR created automatically by Jules for task 2504216671905138682 started by @MarsLuay