🧪 [testing improvement] Add tests for translations logic - #59
Conversation
This change introduces `source/services/app/translations.test.ts` to test the `translations.ts` logic. It verifies that: - Supported and unsupported languages are evaluated correctly. - Correct bundle types are retrieved. - Nested JSON translation files are flattened as expected by `buildTranslations`. - English fallback behaves correctly when translations are missing.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🧪 What: Added a testing file for
source/services/app/translations.tsto cover the logic gap where language support utilities and translation bundle structures were previously untested.📊 Coverage: Evaluates the
isSupportedLanguage,getTranslationBundle,getEnglishTranslation, and the nested object flattening inbuildTranslations.✨ Result: Improved confidence in the localization pipeline, ensuring valid translations correctly fallback to defaults and nested JSON definitions flatten gracefully into dot-separated keys.
PR created automatically by Jules for task 4955919240166644313 started by @MarsLuay