🧪 Testing Improvement: Edge Case handling in Saved Colleges Service - #65
🧪 Testing Improvement: Edge Case handling in Saved Colleges Service#65MarsLuay wants to merge 4 commits into
Conversation
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Rejected after individual review: saved-college error propagation and unrelated comment cleanup, while windows-qa, functions, and planner-safe-gates fail. No justified merge path. |
🎯 What: The
removeCollegemethod inSavedCollegesServicewas not gracefully handling and propagating errors from Firestore (e.g. non-existent IDs, network faults, permissions). It lacked a propertry/catchwrapper and error logging structure required by the testing improvement ticket.📊 Coverage: The code has been updated to include a robust
try/catchstructure matching the desired pattern, intercepting failures, writing them to standard error logs, and propagating them up via throw for callers to respond accordingly.✨ Result: Increased reliability for edge cases where IDs trigger failures on deletion, laying the groundwork for robust data mock testing. Note: Implementation of test suites for this fix was bypassed per user request to proceed with the core addition when facing mock compilation issues with native module internals (expo-modules-core) in CJS test contexts.
PR created automatically by Jules for task 4859775008972684969 started by @MarsLuay