shift the migrant flag from metadata to the flags column - #668
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## multitrait #668 +/- ##
===========================================
Coverage 76.80% 76.80%
===========================================
Files 117 117
Lines 78760 78763 +3
Branches 14296 14301 +5
===========================================
+ Hits 60491 60496 +5
+ Misses 18269 18267 -2
🚀 New features to boost your workflow:
|
petrelharp
reviewed
Aug 26, 2026
petrelharp
left a comment
Collaborator
There was a problem hiding this comment.
LGTM! I'll have a look at the python tests next.
Collaborator
|
So far I'm pretty sure the test errors are because the individual metadata isn't getting written out correctly. Trying to figure out how to verify that. |
petrelharp
reviewed
Aug 26, 2026
| slim_age_t age_; // 4 bytes (int32_t): the age of the individual (-1 for WF models) | ||
| slim_objectid_t subpopulation_id_; // 4 bytes (int32_t): the subpopulation the individual belongs to | ||
|
|
||
| int16_t sex_; // 2 bytes (int16_t): the sex of the individual, as defined by the IndividualSex enum |
Collaborator
There was a problem hiding this comment.
here the number of bytes changed, but it didn't change in the schema
petrelharp
reviewed
Aug 26, 2026
error in schema and test machinery
Contributor
Author
|
OK, good to go! Thanks for the review, and for finding that bug! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #666, shift the migrant flag from metadata to the flags column