test(base-data-service): Use fake timers - #9496
Merged
Merged
Conversation
FrederikBolding
marked this pull request as ready for review
July 14, 2026 08:12
FrederikBolding
temporarily deployed
to
default-branch
July 14, 2026 08:12 — with 
GitHub Actions
Inactive
GitHub Actions
Inactive
FrederikBolding
enabled auto-merge
July 14, 2026 08:12
Mrtenz
reviewed
Jul 14, 2026
| */ | ||
| destroy(): void { | ||
| this.#queryCacheUnsubscribe(); | ||
| this.#queryClient.clear(); |
Member
There was a problem hiding this comment.
Is this related to the tests or does this fix another bug? 🤔
Member
Author
There was a problem hiding this comment.
The tests would hang waiting for a GC timer without this
Member
Author
There was a problem hiding this comment.
Though it makes sense to clear it out when destroying regardless!
Mrtenz
approved these changes
Jul 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
Separated out for review from #9445, since it is needed for multiple PRs. Makes it easier to write tests for
BaseDataServicegoing forward.References
N/A
Checklist