Fix incorrect C++/WinRT Frame instantiation syntax in navigation tutorial - #6062
Closed
GrantMeStrength with Copilot wants to merge 2 commits into
Closed
Fix incorrect C++/WinRT Frame instantiation syntax in navigation tutorial#6062GrantMeStrength with Copilot wants to merge 2 commits into
GrantMeStrength with Copilot wants to merge 2 commits into
Conversation
Contributor
|
Learn Build status updates of commit 751597b:
|
Copilot
AI
changed the title
[WIP] Fix incorrect code string for Frame initialization
Fix incorrect C++/WinRT Frame instantiation syntax in navigation tutorial
Jul 27, 2026
Contributor
|
Learn Build status updates of commit 0097f88: ✅ Validation status: passed
For more details, please refer to the build report. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR corrects the C++/WinRT sample in the “navigate between two pages” tutorial so the Frame is instantiated using idiomatic C++/WinRT brace-initialization (Frame rootFrame{};) rather than the non-idiomatic/incorrect Frame rootFrame = Frame();.
Changes:
- Updated the C++/WinRT
OnLaunchedsnippet to useFrame rootFrame{};for proper default activation.
| { | ||
| window = make<MainWindow>(); | ||
| Frame rootFrame = Frame(); | ||
| Frame rootFrame{}; |
GrantMeStrength
approved these changes
Jul 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The C++/WinRT code snippet in the two-page navigation tutorial used
Frame rootFrame = Frame();— a C# pattern (new Frame()) withnewremoved, which is not valid idiomatic C++/WinRT.Change
Replaced with the correct brace-initialization form, which invokes the WinRT activation factory's default constructor:
This is consistent with how other C++/WinRT examples across the docs repo instantiate WinRT runtime classes (e.g.,
Frame rootFrame{ nullptr };for null handles,Frame rootFrame{};for default-constructed objects).