Fix incorrect BasedOn guidance for WinUI 3 controls in xaml-styles.md - #6068
Draft
GrantMeStrength with Copilot wants to merge 2 commits into
Draft
Fix incorrect BasedOn guidance for WinUI 3 controls in xaml-styles.md#6068GrantMeStrength with Copilot wants to merge 2 commits into
GrantMeStrength with Copilot wants to merge 2 commits into
Conversation
Contributor
|
Learn Build status updates of commit 3ad9c6b:
|
Copilot
AI
changed the title
[WIP] Update button styles for WinUI3 controls
Fix incorrect BasedOn guidance for WinUI 3 controls in xaml-styles.md
Jul 30, 2026
Contributor
|
Learn Build status updates of commit 00889e7: ✅ Validation status: passed
For more details, please refer to the build report. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "Avoid restyling controls" section incorrectly told WinUI 3 developers to omit
BasedOnforMicrosoft.UI.Xaml.Controlscontrols. In WinUI 3, omittingBasedOncompletely replaces the default style—stripping rounded corners, theming, and all other WinUI 3 visual defaults (as the reporter's screenshots show).Changes
BasedOnguidance: Replace the two-namespace paragraph split (which conflated WinUI 2/UWP with WinUI 3) with a single unambiguous rule: always useBasedOn="{StaticResource Default<ControlName>Style}"forMicrosoft.UI.Xaml.Controlscontrols in WinUI 3.Windows.UI.Xaml.Controlsguidance was irrelevant to WinUI 3 apps and caused the namespace confusion the reporter hit.Button/DefaultButtonStylematching the reporter's scenario.ms.dateto reflect the substantive content change.