-
Notifications
You must be signed in to change notification settings - Fork 3
Stop a Parlio resize from crashing the board, and tell a new device its own address #64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| // A 3D lattice: stacked layers of a grid, the primitive 3D space of LED strips. | ||
| // `z` is an ordinary axis to a layout -- the shipped 2D layouts simply pass 0 for it. | ||
| // Three nested loops need more registers than Xtensa has, so this runs on P4/S31/desktop | ||
| // but not the S3; two loops (grid.mlv) fit everywhere. | ||
| uint8_t cols = 4; // @control 1..32 | ||
| uint8_t rows = 3; // @control 1..32 | ||
| uint8_t layers = 5; // @control 1..32 | ||
|
|
||
| for (z = 0; z < layers; z = z + 1) { | ||
| for (y = 0; y < rows; y = y + 1) { | ||
| for (x = 0; x < cols; x = x + 1) { | ||
| addLight(x, y, z); | ||
| } | ||
| } | ||
| } | ||
|
Comment on lines
+1
to
+15
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🎯 Functional Correctness | 🔵 Trivial | ⚡ Quick win Add or verify a 3D coordinate regression test. This script must emit 60 coordinates for 🤖 Prompt for AI Agents |
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎯 Functional Correctness | 🟠 Major | ⚡ Quick win
Clarify the over-limit Parlio result.
At 16,384 lights across 8 lanes, the row contains 2,048 lights per lane. This exceeds the stated RGB ceiling of 898 lights per lane. Do not present the 30,100 microsecond value as a successful 16,384-light transmission. Label it as an over-limit refusal/dead-frame measurement, or replace it with a within-limit result.
As per coding guidelines: “Documentation must describe the system as it currently exists.”
🤖 Prompt for AI Agents
Source: Coding guidelines