feat(kimi-code): specialize the WaitFor tool's transcript display - #3066
Conversation
🦋 Changeset detectedLatest commit: 0f6f2a2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4ed95cb447
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review All three suggestions from the last round are addressed in separate commits:
Each commit carries its own tests; full suites pass locally (agent-core-v2 5282, kimi-code TUI 2141, protocol 535, klient 108). |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e13ab05ebb
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review Third round addressed, one commit per suggestion:
Full suites green locally (agent-core-v2 5283, kimi-code TUI 2142, protocol 535, klient 108). The |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9ffe7073a8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review Fourth round addressed:
agent-core-v2 full suite green locally (5283); kap-server typecheck green. Note: kap-server's |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0a78a3617c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review Fifth round: the child-agent status path now forwards the text without the appended newline (72d19ac) — with replace semantics the buffer resets every tick, so the separator was only producing a blank row that pushed the elapsed/timeout values out of the narrow two-row window. kimi-code TUI suites green locally (2142). |
|
Codex Review: Didn't find any major issues. 🎉 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
72d19ac to
c749138
Compare
|
@codex review Two more commits since the last review: per-second progress ticks (4b42116 — the progress event is transient/observable-only, not written to the wire log, so a 1s cadence is just one bus publish + one card re-render) and duration formatting (34d1c38 — |
|
Codex Review: Didn't find any major issues. What shall we delve into next? Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Related Issue
Stacks on #3060 (the WaitFor tool). When that PR merges, GitHub will retarget this one to
mainautomatically.Problem
WaitForcurrently renders through the generic transcript path: aUsed WaitFor (task_id)header plus the first 3 lines of the raw key-value output. The interesting facts — which task the wait returned with, its outcome, what else finished during the window, and what is still running — are buried in the collapsed... (N more lines)tail. While the wait is pending (up to 600s), the card is completely static with no indication of progress.What changed
tool-renderers/wait-for.ts, registered inregistry.ts): parses the wait timeline and renders a glance —✓ question-80w0h7nw completed · <description>(or✗ … failed), then+N more finished during wait · M background tasks still running; timeouts list the still-running tasks by description. Expanding still shows the full raw output. Errors fall back to the truncated renderer.Waiting for background task (id)while pending,Waited for background task (id)once completed,Wait timed out (id)in the warning tone (a timeout is not an error),Could not wait for background taskon error.· 10snext to the header once the wait returns.WaitForToolemits anonUpdatestatus every 10s (Waiting 30s / 600s · 2 background tasks still running), rendered by the existing progress pipeline as dim lines inside the card.Checklist
registry.test.ts, header cases intool-call.test.ts, progress emission in agent-core-v2'stask-tools.test.ts).gen-changesetsskill (two patch changesets, one per logical change).