Split vector<MCRelationship> branches for uproot - #387
Open
AndrewEdmonds11 wants to merge 1 commit into
Open
Conversation
sophiemiddleton
approved these changes
Jul 27, 2026
sophiemiddleton
left a comment
sophiemiddleton
left a comment
Collaborator
There was a problem hiding this comment.
Looks good. Should we do something about this too:
https://github.com/Mu2e/EventNtuple/blob/main/inc/SimInfo.hh#L30
More generally MCRelationship doesnt interface well with python. We could make a new issue for this if necessary
Collaborator
Author
|
So the crash we were seeing was because of |
Collaborator
|
For me there is no crash in this case. I'm just thinking in terms of consistency. It is not an urgent issue |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR splits leaves that are
vector<MCRelationship>since uproot cannot read the branches that contain them