Skip to content

Fix LineFinder build: migrate to calo transform API from #1908 - #1912

Merged
oksuzian merged 1 commit into
Mu2e:mainfrom
oksuzian:fix-linefinder-geomutil
Aug 1, 2026
Merged

Fix LineFinder build: migrate to calo transform API from #1908#1912
oksuzian merged 1 commit into
Mu2e:mainfrom
oksuzian:fix-linefinder-geomutil

Conversation

@oksuzian

@oksuzian oksuzian commented Aug 1, 2026

Copy link
Copy Markdown
Collaborator

Main is currently broken for every PR buildtest: #1908 removed Calorimeter::geomUtil()/CaloGeomUtil, but the calo-cluster matching added to LineFinder in 0d17255 (2026-07-20, after #1908 branched) still calls it, so CosmicReco/src/LineFinder_module.cc no longer compiles against main (e9b2fbd1). First seen on #1911's retest:

scons: *** [build/al9-prof-e29-p103/Offline/tmp/CosmicReco/src/LineFinder_module.os] Error 1

Any PR retested against current main fails the same way, on a file it doesn't touch.

This migrates the one surviving call site to the transforms #1908 hoisted onto the Calorimeter interface — the same pattern #1908 itself applied in CalPatRec (CalTimePeakFinder_module.cc:203-204, CalLineTimePeakFinder_module.cc:154-155):

- _calorimeter->geomUtil().mu2eToTracker(_calorimeter->geomUtil().diskToMu2e(cl.diskID(), cl.cog3Vector()));
+ _calorimeter->mu2eToTracker(_calorimeter->diskToMu2e(cl.diskID(), cl.cog3Vector()));

The transforms are numerically identical to the old CaloGeomUtil ones, so this is a pure compile fix with no behavior change. grep -rn geomUtil confirms this was the only remaining reference in the tree.

🤖 Generated with Claude Code

Calorimeter::geomUtil()/CaloGeomUtil were removed in Mu2e#1908, but the
calo-cluster matching added to LineFinder in 0d17255 (2026-07-20,
after that PR branched) still called them, breaking main for every
PR buildtest. Migrate the one surviving call site to the hoisted
transforms, matching how Mu2e#1908 migrated the identical pattern in
CalPatRec (CalTimePeakFinder, CalLineTimePeakFinder).

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@FNALbuild

Copy link
Copy Markdown
Collaborator

Hi @oksuzian,
You have proposed changes to files in these packages:

  • CosmicReco

which require these tests: build.

@Mu2e/fnalbuild-users, @Mu2e/write have access to CI actions on main.

⌛ The following tests have been triggered for 4ea39b2: build (Build queue - API unavailable)

About FNALbuild. Code review on Mu2e/Offline.

@FNALbuild

Copy link
Copy Markdown
Collaborator

☀️ The build tests passed at 4ea39b2.

Test Result Details
test with Command did not list any other PRs to include
merge Merged 4ea39b2 at e9b2fbd
build (prof) Log file. Build time: 04 min 20 sec
ceSimReco Log file.
g4test_03MT Log file.
transportOnly Log file.
POT Log file.
g4study Log file.
cosmicSimReco Log file.
cosmicOffSpill Log file.
ceSteps Log file.
ceDigi Log file.
muDauSteps Log file.
ceMix Log file.
rootOverlaps Log file.
g4surfaceCheck Log file.
trigger Log file.
check_cmake Log file.
FIXME, TODO TODO (0) FIXME (0) in 1 files
clang-tidy ➡️ 2 errors 18 warnings
whitespace check no whitespace errors found

N.B. These results were obtained from a build of this Pull Request at 4ea39b2 after being merged into the base branch at e9b2fbd.

For more information, please check the job page here.
Build artifacts are deleted after 5 days. If this is not desired, select Keep this build forever on the job page.

@oksuzian
oksuzian merged commit ed58b12 into Mu2e:main Aug 1, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants