Fix LineFinder build: migrate to calo transform API from #1908 - #1912
Merged
Conversation
Calorimeter::geomUtil()/CaloGeomUtil were removed in Mu2e#1908, but the calo-cluster matching added to LineFinder in 0d17255 (2026-07-20, after that PR branched) still called them, breaking main for every PR buildtest. Migrate the one surviving call site to the hoisted transforms, matching how Mu2e#1908 migrated the identical pattern in CalPatRec (CalTimePeakFinder, CalLineTimePeakFinder). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Collaborator
|
☀️ The build tests passed at 4ea39b2.
N.B. These results were obtained from a build of this Pull Request at 4ea39b2 after being merged into the base branch at e9b2fbd. For more information, please check the job page here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main is currently broken for every PR buildtest: #1908 removed
Calorimeter::geomUtil()/CaloGeomUtil, but the calo-cluster matching added toLineFinderin 0d17255 (2026-07-20, after #1908 branched) still calls it, soCosmicReco/src/LineFinder_module.ccno longer compiles against main (e9b2fbd1). First seen on #1911's retest:Any PR retested against current main fails the same way, on a file it doesn't touch.
This migrates the one surviving call site to the transforms #1908 hoisted onto the
Calorimeterinterface — the same pattern #1908 itself applied inCalPatRec(CalTimePeakFinder_module.cc:203-204,CalLineTimePeakFinder_module.cc:154-155):The transforms are numerically identical to the old
CaloGeomUtilones, so this is a pure compile fix with no behavior change.grep -rn geomUtilconfirms this was the only remaining reference in the tree.🤖 Generated with Claude Code