Install CalorimeterGeom/data in the CMake build (fixes spack ceSimReco) - #1914
Open
oksuzian wants to merge 2 commits into
Open
Install CalorimeterGeom/data in the CMake build (fixes spack ceSimReco)#1914oksuzian wants to merge 2 commits into
oksuzian wants to merge 2 commits into
Conversation
crystalPos.txt (added in Mu2e#1908) is opened at runtime via ConfigFileLookupPolicy from geom key calorimeter.diskCrystalFile, but CalorimeterGeom had no install rule for data/ -- a spack/CMake install ships without the file and any calo-geometry job dies: Can't find file "Offline/CalorimeterGeom/data/crystalPos.txt" The existing configure_file line only stages the file into the build tree. Add the install(DIRECTORY data ...) rule every other package shipping runtime data uses (Mu2eG4, TrackerConditions, CaloConditions, CalPatRec, CRVConditions, ...). The scons build reads the source tree and is unaffected. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Collaborator
|
☀️ The build tests passed at 932a053.
N.B. These results were obtained from a build of this Pull Request at 932a053 after being merged into the base branch at ed58b12. For more information, please check the job page here. |
rlcee
requested changes
Aug 1, 2026
rlcee
left a comment
Collaborator
There was a problem hiding this comment.
You want to remove the configure_file a few line above
Per review: the install(DIRECTORY data ...) rule makes the configure_file staging redundant; build-tree runs resolve the file from the source tree via MU2E_SEARCH_PATH, matching how Mu2eG4 and the other data-shipping packages work (install rule only). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Collaborator
Author
|
Removed the configure_file line in ceb9a3a — the install rule alone matches how Mu2eG4 and the other data-shipping packages handle it. |
rlcee
approved these changes
Aug 1, 2026
Collaborator
Author
|
@FNALbuild run build test |
Collaborator
|
⌛ The following tests have been triggered for ceb9a3a: build (Build queue - API unavailable) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the spack/CMake runtime failure reported this morning:
crystalPos.txt(added in #1908) is opened at runtime viaConfigFileLookupPolicyfrom geom keycalorimeter.diskCrystalFile, so any calo-geometry job (e.g. ceSimReco) needs it onMU2E_SEARCH_PATH.CalorimeterGeom/CMakeLists.txthas no install rule fordata/— theconfigure_fileline only stages the file into the build tree — so a spack/CMake install ships without it. The scons build reads the source tree, which is why CI stayed green.One line, matching every other package that ships runtime data (
Mu2eG4,TrackerConditions,CaloConditions,CalPatRec,CRVConditions,CRVResponse,CaloFilters, …):No behavior change for scons or build-tree runs.
🤖 Generated with Claude Code